PERF: don't materialize arrays on checking in groupby by jreback · Pull Request #16413 · pandas-dev/pandas (original) (raw)

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Conversation3 Commits1 Checks0 Files changed

Conversation

This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters

[ Show hidden characters]({{ revealButtonHref }})

    before     after       ratio
  [a6fcec6c] [6edcdc0d]
-   15.41ms     9.48ms      0.62  groupby.groupby_size.time_groupby_size

this is more dramatic as the size increases as this should be pretty much a constant time operation (the actual size computation itself).

pcluo pushed a commit to pcluo/pandas that referenced this pull request

May 22, 2017

TomAugspurger pushed a commit to TomAugspurger/pandas that referenced this pull request

May 29, 2017

(cherry picked from commit d5a681b)

This was referenced

Jun 4, 2017

stangirala pushed a commit to stangirala/pandas that referenced this pull request

Jun 11, 2017

2 participants