ERR: Raise ImportError when xlrd is not present by gcbeltramini · Pull Request #17613 · pandas-dev/pandas (original) (raw)
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Conversation5 Commits2 Checks0 Files changed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
[ Show hidden characters]({{ revealButtonHref }})
- Related issues: Module xlrd is not installed with 0.14; creates an Import Error when using read_excel #8515, xlrd required for read_excel put not a requirement in setup.py #14673
- tests added / passed
- passes
git diff upstream/master -u -- "*.py" | flake8 --diff - whatsnew entry
| - :func:`DataFrame.items` and :func:`Series.items` is now present in both Python 2 and 3 and is lazy in all cases (:issue:`13918`, :issue:`17213`) |
|---|
| - :func:`Styler.where` has been implemented. It is as a convenience for :func:`Styler.applymap` and enables simple DataFrame styling on the Jupyter notebook (:issue:`17474`). |
| - :func:`MultiIndex.is_monotonic_decreasing` has been implemented. Previously returned ``False`` in all cases. (:issue:`16554`) |
| - :func:`read_excel` raises ``ImportError`` with better message if ``xlrd`` is not installed |
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reference your PR here.
| raise ImportError("pandas requires xlrd >= 0.9.0 for excel " |
|---|
| "support, current version " + xlrd.__VERSION__) |
| err_msg = "Install xlrd >= 0.9.0 for Excel support" |
| try: |
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Newline above this one.
Throw ImportError ERR: Raise ImportError when xlrd is not present
alanbato pushed a commit to alanbato/pandas that referenced this pull request
Related issues: pandas-dev#8515, pandas-dev#14673
Author: Guilherme Beltramini guilherme.beltramini@nubank.com.br
Closes pandas-dev#17613 from gcbeltramini/xlrd-import and squashes the following commits:
dee1998 [Guilherme Beltramini] Add PR number and blank line c2759cb [Guilherme Beltramini] Throw ImportError
No-Stream pushed a commit to No-Stream/pandas that referenced this pull request
Related issues: pandas-dev#8515, pandas-dev#14673
Author: Guilherme Beltramini guilherme.beltramini@nubank.com.br
Closes pandas-dev#17613 from gcbeltramini/xlrd-import and squashes the following commits:
dee1998 [Guilherme Beltramini] Add PR number and blank line c2759cb [Guilherme Beltramini] Throw ImportError