Implement missing tests, fix offset floordiv, rfloordiv, fix return types by jbrockmendel · Pull Request #19738 · pandas-dev/pandas (original) (raw)
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Conversation6 Commits5 Checks0 Files changed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
[ Show hidden characters]({{ revealButtonHref }})
This splits off of #19365 a bunch of peripheral changes that were never intended to be part of #19365 in the first place.
- Implements many tests in the "how is there not already a test for that!?" category
- Fixes(+tests) Timedelta // DateOffset and DateOffset // Timedelta
- Fixes(+tests) return types for
Timedelta.__add__, __radd__, __sub__, __rsub__(np.timedelta64)(ATM returnstimedelta64) - Fixes a typo in test_construction that causes a dummy assertion to be made instead of the intended assertion.
- closes #xxxx
- tests added / passed
- passes
git diff upstream/master -u -- "*.py" | flake8 --diff - whatsnew entry
| @@ -13,6 +16,135 @@ |
|---|
| class TestTimedeltaArithmetic(object): |
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
as I said in another PR, pls create a
pandas/tests/scalar/timedelta/test_arithmetic to add these 2
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
let's do that first so that its then easier to see the changes in this.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
OK. Will open a new PR that just moves tests without making any actual changes.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Edit: it will add tests that currently pass, will not remove any existing tests or touch anything outside of the tests.
This was referenced
Feb 18, 2018
Closing n favor of #19752 plus followups
Labels
pandas testing functions or related to the test suite
Timedelta data type
2 participants
