Fix rfloordiv return type, un-xfail Timedelta tests by jbrockmendel · Pull Request #19820 · pandas-dev/pandas (original) (raw)

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Conversation5 Commits3 Checks0 Files changed

Conversation

This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters

[ Show hidden characters]({{ revealButtonHref }})

jbrockmendel

@jbrockmendel

@codecov

@jreback jreback added Timedelta

Timedelta data type

Compat

pandas objects compatability with Numpy or Python functions

labels

Feb 22, 2018

jreback

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

doc comment. ping when pushed.

@@ -744,6 +744,7 @@ Timedelta
- Bug in :func:`Timedelta.__floordiv__`, :func:`Timedelta.__rfloordiv__` where operating with a ``Tick`` object would raise a ``TypeError`` instead of returning a numeric value (:issue:`19738`)
- Bug in :func:`Period.asfreq` where periods near ``datetime(1, 1, 1)`` could be converted incorrectly (:issue:`19643`)
- Bug in :func:`Timedelta.total_seconds()` causing precision errors i.e. ``Timedelta('30S').total_seconds()==30.000000000000004`` (:issue:`19458`)
- Bug in :func: `Timedelta.__rmod__` where operating with a ``numpy.timedelta64`` returned a ``timedelta64`` object instead of a ``Timedelta`` (:issue:`19378`)

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is not the correct reference, can you update?

@jreback

needs rebase actually. ping on green.

@jbrockmendel

@jbrockmendel

jreback

@jreback

harisbal pushed a commit to harisbal/pandas that referenced this pull request

Feb 28, 2018

@jbrockmendel

Labels

Compat

pandas objects compatability with Numpy or Python functions

Timedelta

Timedelta data type

2 participants

@jbrockmendel @jreback