BUG/TST/REF: Datetimelike Arithmetic Methods by jbrockmendel · Pull Request #23215 · pandas-dev/pandas (original) (raw)

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you then add a comment on this function indicating the types? That really makes it easier to read through this code

But, to my original question: this function uses _addsub_int_array, which is defined a little bit above to return a PeriodArray, and not a i8 array.
I assume in practice this is not really a problem, because the code that converts the i8 array to PeriodArray, will also accept a PeriodArray.