DEPR: deprecate SparseArray.values by jorisvandenbossche · Pull Request #26421 · pandas-dev/pandas (original) (raw)

+1

…

On Mon, May 20, 2019 at 8:18 AM Joris Van den Bossche < ***@***.***> wrote: ***@***.**** commented on this pull request. ------------------------------ In pandas/_libs/reduction.pyx <#26421 (comment)>: > @@ -28,6 +28,14 @@ cdef _get_result_array(object obj, Py_ssize_t size, Py_ssize_t cnt): return np.empty(size, dtype='O') +cdef bint _is_sparse_array(object obj): Yes, exactly for those reasons (It's only used here, and should be removed again once we get rid of this deprecation), I would keep it here — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#26421?email_source=notifications&email_token=AAKAOIS6HRAYVGNAUBPWWMDPWKQJZA5CNFSM4HNKAIJ2YY3PNVWWK3TUL52HS4DFWFIHK3DMKJSXC5LFON2FEZLWNFSXPKTDN5WW2ZLOORPWSZGOBZDF2AQ#discussion_r285587187>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AAKAOIXL3A3WPZHBHQW2H7TPWKQJZANCNFSM4HNKAIJQ> .