DEPR: is_extension_type by jbrockmendel · Pull Request #29457 · pandas-dev/pandas (original) (raw)
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Conversation11 Commits4 Checks0 Files changed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
[ Show hidden characters]({{ revealButtonHref }})
It is mostly redundant with is_extension_array_dtype, and having both is confusing.
xref #23179.
Can this not be removed outright? It's non-public and sits behind an experimental interface, so I think not worth the effort of a deprecation cycle
i wouldnt shed any tears if we removed it altogether
is this in pd.api.types?
if not ok to remove
It’s not public right? So fine to just remove. This predated the EA interface.
On Nov 7, 2019, at 18:23, William Ayd ***@***.***> wrote: I'm +1 to outright remove but let's see what @TomAugspurger and @jreback think — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub, or unsubscribe.
is this in pd.api.types?
Yes, this is in pd.api.types. (via a * import)
is this in pd.api.types?
Yes, this is in pd.api.types. (via a
*import)
really? it has a test that catches the earning?
We have tests (updated appropriately in this PR) for deprecated functions in this module.
On Thu, Nov 7, 2019 at 5:29 PM Jeff Reback ***@***.***> wrote: is this in pd.api.types? Yes, this is in pd.api.types. (via a * import) really? it has a test that catches the earning? — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <#29457?email_source=notifications&email_token=AB5UM6CRGPV2CITZPCDWCB3QSS6GNA5CNFSM4JKBUAJ2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEDONGXQ#issuecomment-551342942>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AB5UM6DGRZX6UENGSIFMSMDQSS6GNANCNFSM4JKBUAJQ> .
ok i see the change now, yeah have to deprecate
can u add to the master depreciation issue (or create say a 1.2 removals issue)
can u add to the master depreciation issue (or create say a 1.2 removals issue)
will do
Reksbril pushed a commit to Reksbril/pandas that referenced this pull request
proost pushed a commit to proost/pandas that referenced this pull request
proost pushed a commit to proost/pandas that referenced this pull request