DEPR: enforce deprecations in core.internals by jbrockmendel · Pull Request #29723 · pandas-dev/pandas (original) (raw)
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Conversation14 Commits7 Checks0 Files changed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
[ Show hidden characters]({{ revealButtonHref }})
Not sure if the whatsnew is needed for this; IIRC it was mainly pyarrow/fastparquet that were using these keywords
| @@ -311,7 +311,8 @@ def test_delete(self): |
|---|
| def test_make_block_same_class(self): |
| # issue 19431 |
| block = create_block("M8[ns, US/Eastern]", [3]) |
| with tm.assert_produces_warning(FutureWarning, check_stacklevel=False): |
| with pytest.raises(TypeError, match="unexpected keyword"): |
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we just remove the dtype argument from this test instead of catching this?
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
without the dtpye kwarg its just a smoke test, at which point id rather just remove this test (which id be completely fine with)
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think OK then. As is this isn't testing anything pandas related just the stdlib
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
*OK to remove
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
removed
the travis-36-locale build uses fastparquet=0.2.1 which apparently still passes dtype to make_block_same_class. any objection to bumping the required version?
Looks like we last bumped the fastparquet version in #24590
Yes, I think bumping the minimum fastparquet version is fine.
cc @TomAugspurger
Yes, I think bumping the minimum fastparquet version is fine.
cc @TomAugspurger
agreed here as well.
bumped fastparquet to 0.3.0. Wasnt sure what to put in the whatsnew, so I copied the whole minimum-version section from 0.25.0, updated the fastparquet entry, and cut the sentence about py27 having just been dropped.
Looks like 0.3.2 is the version when fastparquet stopped using the deprecated keyword, but that is also the most recent version. are we OK with bumping that far?
looks good, IIRC you have a nother PR where you add the Change column, can update then.
jbrockmendel added a commit to jbrockmendel/pandas that referenced this pull request
keechongtan added a commit to keechongtan/pandas that referenced this pull request
proost pushed a commit to proost/pandas that referenced this pull request
proost pushed a commit to proost/pandas that referenced this pull request