Deprecate Aliases as orient Argument in DataFrame.to_dict by elmonsomiat · Pull Request #32516 · pandas-dev/pandas (original) (raw)

Overall LGTM. ex @WillAyd comment that we should deprecate it, I believe that we should at least give a Deprecation warning. so I was thinking some thing with the style of:

orient = orient.lower()

if orient in {'i', 's', 'sp', ... }: warnings.warn("Using short name for 'orient' is deprecated...", DeprecationWarning, stacklevel=2) if orient == "i": orient = "index" elif orient == "l": orient = "list" ...

And then below the rest of your code.