pandas (original) (raw)

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Conversation3 Commits3 Checks0 Files changed

Conversation

This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters

[ Show hidden characters]({{ revealButtonHref }})

closes #xxxx
tests added / passed
passes black pandas
passes git diff upstream/master -u -- "*.py" | flake8 --diff
whatsnew entry

Also improve _can_fast_intersect to catch the missing case where we can fast-intersect. Identified that most of the remaining places where we do freq inference are not tested, so may be removeable/deprecateable

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm. trivial comment (followup ok), does this need a whatsnew? e.g. is it user visible

# so intersection will preserve freq
return True

if isinstance(self.freq, Tick):

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

could be an elif

does this need a whatsnew?

yes, just pushed with a note added

Identified that most of the remaining places where we do freq inference are not tested, so may be removeable/deprecateable

on board with this for follow-up?

rhshadrach pushed a commit to rhshadrach/pandas that referenced this pull request

May 10, 2020

2 participants