#34640: CLN: remove 'private_key' and 'verbose' from gbq by parkdj1 · Pull Request #34654 · pandas-dev/pandas (original) (raw)

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Conversation17 Commits21 Checks0 Files changed

Conversation

This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters

[ Show hidden characters]({{ revealButtonHref }})

[x ] closes CLN: remove private_key and verbose from gbq #34640
tests added / passed
passes black pandas
passes git diff upstream/master -u -- "*.py" | flake8 --diff
whatsnew entry

Hello, I am new to contributing to open source, so thank you in advance for any corrections and suggestions. Please let me know if I need to do anything else for this ticket!

I removed the code containing both 'private_key' and 'verbose' from the gbq.py file.

since those two kwargs weren't removed along with #30200 , also cc @jbrockmendel , just in case this was made on purpose by him.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can you add a note in other api changes section for 1.1 that these keywords were removed, also please merge master and ping on green.

- Using a :func:`pandas.api.indexers.BaseIndexer` with ``count``, ``min``, ``max``, ``median``, ``skew``, ``cov``, ``corr`` will now return correct results for any monotonic :func:`pandas.api.indexers.BaseIndexer` descendant (:issue:`32865`)
- Added a :func:`pandas.api.indexers.FixedForwardWindowIndexer` class to support forward-looking windows during ``rolling`` operations.
-
- Removed ``private_key`` and ``verbose`` from gbq (:issue:`34654`)

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can you co-locate this with the other issue where we removed a keyword from gbq; also pls use the references to read_gbq (see the other issue)

@parkdj1

hi, you need to rebase and resolve the conflicts in the two files listed below, otherwise, your commit won't get through and make CI run.

@parkdj1 - Thanks for the PR, can you address the test failures and fix up the commits seems to be a few unrelated changes.

Hello @parkdj1! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:

There are currently no PEP 8 issues detected in this Pull Request. Cheers! 🍻

Comment last updated at 2020-09-22 22:31:42 UTC

Hello @parkdj1! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:

There are currently no PEP 8 issues detected in this Pull Request. Cheers! 🍻

Comment last updated at 2020-06-29 00:35:21 UTC

Awesome, thank you!