BUG: Series construction with mismatched dt64 data vs td64 dtype by jbrockmendel · Pull Request #38764 · pandas-dev/pandas (original) (raw)
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Conversation3 Commits3 Checks0 Files changed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
[ Show hidden characters]({{ revealButtonHref }})
- closes #xxxx
- tests added / passed
- passes
black pandas - passes
git diff upstream/master -u -- "*.py" | flake8 --diff - whatsnew entry
Fixing this for DataFrame is much harder, so punting for now.
looks fine. this is just a refactor right? doesn't change user facing?
looks fine. this is just a refactor right? doesn't change user facing?
No, this fixes corner cases failing to raise:
dtype = np.dtype("m8[ns]")
val = np.datetime64(1234, "ns")
>>> pd.Series([val], dtype=dtype)
>>> pd.Series({0: val}, dtype=dtype)
and vice-versa for flipping tdt64/dt64
kk i guess then a whatsnew note
luckyvs1 pushed a commit to luckyvs1/pandas that referenced this pull request
