ENH: New boundary inputs by hewittk · Pull Request #40628 · pandas-dev/pandas (original) (raw)

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Conversation74 Commits89 Checks0 Files changed

Conversation

This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters

[ Show hidden characters]({{ revealButtonHref }})

Ensure all linting tests pass, see here for how to run them
tests added / passed
closes ENH: consistency of input args for boundaries #40245
whatsnew entry

Kiley added 9 commits

March 19, 2021 15:42

Hello @hewittk! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:

There are currently no PEP 8 issues detected in this Pull Request. Cheers! 🍻

Comment last updated at 2021-06-25 03:56:00 UTC

Kiley added 3 commits

March 25, 2021 02:12

hewittk marked this pull request as ready for review

March 25, 2021 12:34

This pull request makes for more consistency and flexibility of the arguments for series.between and the validate_endpoints method of date_timelike.py which is the underlying method of closed for date_range. The parameters that can be inputted to the methods are either a boolean value or a string value of 'both', 'left', 'right', or 'neither'.

hewittk changed the title~~New boundary inputs~~ ENH: New boundary inputs

Mar 25, 2021

Thanks for the pr @hewittk! Looks like some unrelated changes crept in - seeing some pip related additions which should be reverted

Thank you for letting me know @mzeitlin11! The pip files should be deleted now, let me know if there are any unrelated additions still there that I haven't noticed.

Thank you for letting me know @mzeitlin11! The pip files should be deleted now, let me know if there are any unrelated additions still there that I haven't noticed.

Looks good now. I think codecov is failing - if you added new options to parameters, we need to make sure that they're all tested (and a whatsnew note should be added explaining user-facing changes there are here)

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @hewittk for the PR. I made some comments inline. Some of the changes minght be considered non-controversial, and others we might some input from pandas core devs.

Kiley and others added 6 commits

March 25, 2021 21:37