BUG: DataFrame.at with CategoricalIndex by jbrockmendel · Pull Request #41846 · pandas-dev/pandas (original) (raw)
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Conversation18 Commits3 Checks0 Files changed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
[ Show hidden characters]({{ revealButtonHref }})
- closes #xxxx
- tests added / passed
- Ensure all linting tests pass, see here for how to run them
- whatsnew entry
| col = self.columns.get_loc(col) |
|---|
| index = self.index.get_loc(index) |
| return self._get_value(index, col, takeable=True) |
| except AttributeError: |
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
on the list to add?
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
once this is merged ill push my branch that implements IntervalTree.get_loc, getting rid of the AttributeError
| Notes |
| ----- |
| Assumes that index and columns both have ax._index_as_unique; |
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
don't we have this as a base Index property? (or it can raise NotImplementedError), e.g. dont' like the AttributeError checking here.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ill rephrase, it isn't that they have the attribute, it is that this is only called if self.index._index_as_unique and self.columns._index_as_unique
This was referenced
Jun 9, 2021
don't add things to 1.3
when we merge can add if appropriate
This has a release note in 1.3.0 whatsnew. if not 1.3 we need to request it moved. any suggestions how to track this.
i undestand and it prob will be merged but let's look first
eg don't preemptively label (i may have done that here)
its a bugfix so i wrote the note for 1.3, wont be the end of the world if it has to wait for the next one
should i move release note to 1.4 file?
should i move release note to 1.4 file?
not yet. I think Jeff just didn't want stuff added to the 1.3 milestone for now.
if the RC is put off until tomorrow, can this go in? it is a blocker for #41956
Doesn't look like there's a fix for the wheel issue. So may release what we have.
tbc. I should have said we are not necessarily putting off the rc, and that if the wheel issue is not fixed quickly, we could release rc0 and then follow-up with a rc1. So the same backport rules apply. We have a rc0, but may not advertise the fact. So the rc is not put-off, it has effectively happened.
meeseeksmachine pushed a commit to meeseeksmachine/pandas that referenced this pull request
Something went wrong ... Please have a look at my logs.
simonjayhawkins pushed a commit that referenced this pull request
Co-authored-by: jbrockmendel jbrockmendel@gmail.com
JulianWgs pushed a commit to JulianWgs/pandas that referenced this pull request
Labels
Categorical Data Type
Related to indexing on series/frames, not to indexes themselves