DEPR: squeeze argument in read_csv/read_table/read_excel by lithomas1 · Pull Request #43427 · pandas-dev/pandas (original) (raw)
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Conversation15 Commits11 Checks0 Files changed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
[ Show hidden characters]({{ revealButtonHref }})
- closes DEPR: squeeze() argument in read_csv/read_table #43242
- tests added / passed
- Ensure all linting tests pass, see here for how to run them
- whatsnew entry
Wanted some feedback on the new approach to verify stacklevel in the tests.
Also, I'm not sure how to deprecate this for ExcelFile.parse. It will probably warn there as well, but IDK if we need to update the ExcelFile docs.
th.assert_produces_warning should check the stacklevel and raise if is not correct. This should be enough I think?
Wanted some feedback on the new approach to verify stacklevel in the tests.
Also, I'm not sure how to deprecate this for
ExcelFile.parse. It will probably warn there as well, but IDK if we need to update the ExcelFile docs.
ok to tackle in a followup
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
Co-authored-by: gfyoung gfyoung17+GitHub@gmail.com
@phofl Are there other comments that I should address in a follow-up? The current approach is using tm.assert_produces_warning in the conftest since thats where the warnings should be raised.
If OK, I will make another PR updating all the other tests, and changing their stacklevels if necessary.
fkiraly pushed a commit to sktime/sktime that referenced this pull request
zhengruifeng pushed a commit to apache/spark that referenced this pull request
… from read_csv & enabling more tests
What changes were proposed in this pull request?
This PR proposes to remove squeeze parameter from read_csv to follow the behavior of latest pandas. See pandas-dev/pandas#40413 and pandas-dev/pandas#43427 for detail.
This PR also enables more tests for pandas 2.0.0 and above.
Why are the changes needed?
To follow the behavior of latest pandas, and increase the test coverage.
Does this PR introduce any user-facing change?
squeeze will be no longer available from read_csv. Otherwise, it's test-only.
How was this patch tested?
Enabling & updating the existing tests.
Closes #42551 from itholic/pandas_remaining_tests.
Authored-by: itholic haejoon.lee@databricks.com Signed-off-by: Ruifeng Zheng ruifengz@apache.org
valentinp17 pushed a commit to valentinp17/spark that referenced this pull request
… from read_csv & enabling more tests
What changes were proposed in this pull request?
This PR proposes to remove squeeze parameter from read_csv to follow the behavior of latest pandas. See pandas-dev/pandas#40413 and pandas-dev/pandas#43427 for detail.
This PR also enables more tests for pandas 2.0.0 and above.
Why are the changes needed?
To follow the behavior of latest pandas, and increase the test coverage.
Does this PR introduce any user-facing change?
squeeze will be no longer available from read_csv. Otherwise, it's test-only.
How was this patch tested?
Enabling & updating the existing tests.
Closes apache#42551 from itholic/pandas_remaining_tests.
Authored-by: itholic haejoon.lee@databricks.com Signed-off-by: Ruifeng Zheng ruifengz@apache.org
ragnarok56 pushed a commit to ragnarok56/spark that referenced this pull request
… from read_csv & enabling more tests
What changes were proposed in this pull request?
This PR proposes to remove squeeze parameter from read_csv to follow the behavior of latest pandas. See pandas-dev/pandas#40413 and pandas-dev/pandas#43427 for detail.
This PR also enables more tests for pandas 2.0.0 and above.
Why are the changes needed?
To follow the behavior of latest pandas, and increase the test coverage.
Does this PR introduce any user-facing change?
squeeze will be no longer available from read_csv. Otherwise, it's test-only.
How was this patch tested?
Enabling & updating the existing tests.
Closes apache#42551 from itholic/pandas_remaining_tests.
Authored-by: itholic haejoon.lee@databricks.com Signed-off-by: Ruifeng Zheng ruifengz@apache.org