pandas (original) (raw)

Pandas version checks

I have checked that this issue has not already been reported.
I have confirmed this bug exists on the latest version of pandas.
I have confirmed this bug exists on the main branch of pandas.

Reproducible Example

import pandas as pd pd.DataOffset(milliseconds=1, days=1)

Issue Description

TypeError                                 Traceback (most recent call last)
Input In [54], in <cell line: 1>()
----> 1 pd.DateOffset(milliseconds=1, days=1)

File ...pandas/_libs/tslibs/offsets.pyx:1233, in pandas._libs.tslibs.offsets.RelativeDeltaOffset.__init__()

File ...pandas/_libs/tslibs/offsets.pyx:325, in pandas._libs.tslibs.offsets._determine_offset()

TypeError: relativedelta.__init__() got an unexpected keyword argument 'milliseconds'

In contrast, if I pass millisecond (no plural) I get a more useful error:

NotImplementedError: Using DateOffset to replace `millisecond` component in datetime object is not supported. Use `microsecond=timestamp.microsecond % 1000 + ms * 1000` instead.

Expected Behavior

Since DateOffset advertises that it takes milliseconds and millisecond as keyword arguments, it should be possible to construct a DateOffset using those arguments in combination with others.

[I would have a go at fixing this, but I cannot make head or tail of the intended logic in _libs.tslibs.offset._determine_offset. Comments don't appear to match the code behaviour, and I don't know how many moving parts there are here].

Installed Versions

INSTALLED VERSIONS

commit : e41b6d7
python : 3.10.6.final.0
python-bits : 64
OS : Darwin
OS-release : 21.6.0
Version : Darwin Kernel Version 21.6.0: Mon Aug 22 20:19:52 PDT 2022; root:xnu-8020.140.49~2/RELEASE_ARM64_T6000
machine : arm64
processor : arm
byteorder : little
LC_ALL : None
LANG : en_GB.UTF-8
LOCALE : en_GB.UTF-8

pandas : 2.0.0.dev0+643.ge41b6d7827.dirty
numpy : 1.23.4
pytz : 2022.6
dateutil : 2.8.2
setuptools : 65.5.1
pip : 22.3.1
Cython : 0.29.32
pytest : 7.2.0
hypothesis : 6.56.4
sphinx : 4.5.0
blosc : None
feather : None
xlsxwriter : 3.0.3
lxml.etree : 4.9.1
html5lib : 1.1
pymysql : 1.0.2
psycopg2 : 2.9.3
jinja2 : 3.0.3
IPython : 8.6.0
pandas_datareader: 0.10.0
bs4 : 4.11.1
bottleneck : 1.3.5
brotli :
fastparquet : 0.8.3
fsspec : 2021.11.0
gcsfs : 2021.11.0
matplotlib : 3.6.2
numba : 0.56.3
numexpr : 2.8.3
odfpy : None
openpyxl : 3.0.10
pandas_gbq : 0.17.9
pyarrow : 9.0.0
pyreadstat : 1.2.0
pyxlsb : 1.0.10
s3fs : 2021.11.0
scipy : 1.9.3
snappy :
sqlalchemy : 1.4.43
tables : 3.7.0
tabulate : 0.9.0
xarray : 2022.11.0
xlrd : 2.0.1
zstandard : 0.19.0
tzdata : None
qtpy : None
pyqt5 : None