BUG: Silence Period[B] warnings in plotting code by torext · Pull Request #55138 · pandas-dev/pandas (original) (raw)
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Conversation10 Commits3 Checks0 Files changed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
[ Show hidden characters]({{ revealButtonHref }})
- Tests added and passed if fixing a bug or adding a new feature
- All code checks passed.
- Added type annotations to new arguments/methods/functions.
- Added an entry in the latest
doc/source/whatsnew/vX.X.X.rstfile if fixing a bug or adding a new feature.
This silences warnings introduced by #53446 that would happen during normal plotting activity.
Anything else I can do here to get this merged?
torext added 2 commits
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks. Could you add a whatsnew note to 2.1.2.rst?
Thanks. Could you add a whatsnew note to
2.1.2.rst?
Sure thing, @mroeschke, that's done now. Admittedly not completely sure I respected the style of both the entry and the corresponding commit message correctly, apologies in advance if it's not the case!
Owee, I'm MrMeeseeks, Look at me.
There seem to be a conflict, please backport manually. Here are approximate instructions:
- Checkout backport branch and update it.
git checkout 2.1.x
git pull
- Cherry pick the first parent branch of the this PR on top of the older branch:
git cherry-pick -x -m1 6e6a6831aaa2d1606aa897b34f106e655180034b
- You will likely have some merge/cherry-pick conflict here, fix them and commit:
git commit -am 'Backport PR #55138: BUG: Silence `Period[B]` warnings in plotting code'
- Push to a named branch:
git push YOURFORK 2.1.x:auto-backport-of-pr-55138-on-2.1.x
- Create a PR against branch 2.1.x, I would have named this PR:
"Backport PR #55138 on branch 2.1.x (BUG: Silence
Period[B]warnings in plotting code)"
And apply the correct labels and milestones.
Congratulations — you did some good work! Hopefully your backport PR will be tested by the continuous integration and merged soon!
Remember to remove the Still Needs Manual Backport label once the PR gets merged.
If these instructions are inaccurate, feel free to suggest an improvement.
Owee, I'm MrMeeseeks, Look at me.
There seem to be a conflict, please backport manually. Here are approximate instructions:
- Checkout backport branch and update it.
git checkout 2.1.x
git pull
- Cherry pick the first parent branch of the this PR on top of the older branch:
git cherry-pick -x -m1 6e6a6831aaa2d1606aa897b34f106e655180034b
- You will likely have some merge/cherry-pick conflict here, fix them and commit:
git commit -am 'Backport PR #55138: BUG: Silence `Period[B]` warnings in plotting code'
- Push to a named branch:
git push YOURFORK 2.1.x:auto-backport-of-pr-55138-on-2.1.x
- Create a PR against branch 2.1.x, I would have named this PR:
"Backport PR #55138 on branch 2.1.x (BUG: Silence
Period[B]warnings in plotting code)"
And apply the correct labels and milestones.
Congratulations — you did some good work! Hopefully your backport PR will be tested by the continuous integration and merged soon!
Remember to remove the Still Needs Manual Backport label once the PR gets merged.
If these instructions are inaccurate, feel free to suggest an improvement.
mroeschke pushed a commit to mroeschke/pandas that referenced this pull request
mroeschke added a commit that referenced this pull request
Backport PR #55138: BUG: Silence
Period[B]warnings in plotting codeDon't build in parallel to see error
Remove period call
Another suppress?
Co-authored-by: torext torext@users.noreply.github.com