DEPR: lowercase strings `w`, `d`, `b` and `c` denoting frequencies in `Week`, `Day`, `BusinessDay` and `CustomBusinessDay` classes by natmokval · Pull Request #58998 · pandas-dev/pandas (original) (raw)

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Conversation6 Commits10 Checks37 Files changed

Conversation

This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters

[ Show hidden characters]({{ revealButtonHref }})

xref #57986

deprecated lowercase strings d, b and c denoting frequencies in Day, BusinessDay and CustomBusinessDay in favour of D, B and C
deprecated lowercase strings w, w-mon, w-tue, etc. denoting frequencies in Week in favour of W, W-MON, W-TUE, etc.

we can deprecated lowercase strings w, d, b and c for Timedelta in a separate PR

natmokval changed the title~~DEPR: deprecate lowercase aliases 'd' for 'Day'~~ DEPR: lowercase strings w, d, b and c denoting frequencies in Week, Day, BusinessDay and CustomBusinessDay classes

Jun 14, 2024

I deprecated lowercase strings w, d, b and c denoting frequencies in favour of W, D, B and C. @MarcoGorelli, could you please take a look at this PR? I think CI failures are unrelated to my changes.

natmokval marked this pull request as ready for review

June 14, 2024 18:34

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

Given that 2.3 isn't out yet, I wonder if it makes sense to get this in for 2.3, and then in 3.0 we make all these changes in one go and be done with it?

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If in doubt, let's just follow the usual process - deprecate in 3.0, remove thereafter - will merge then if there's no further objections

DEPR: lowercase strings w, d, b and c denoting frequencies in Week, Day, BusinessDay and CustomBusinessDay classes by natmokval · Pull Request #58998 · pandas-dev/pandas (original) (raw)

Conversation

Choose a reason for hiding this comment

Choose a reason for hiding this comment

DEPR: lowercase strings `w`, `d`, `b` and `c` denoting frequencies in `Week`, `Day`, `BusinessDay` and `CustomBusinessDay` classes by natmokval · Pull Request #58998 · pandas-dev/pandas (original) (raw)