pandas (original) (raw)

@sinhrks Docstrings are looking nice! Made some comments (and note that a lot of them are comments on the existing docstrings, but thought was a good opportunity to look at that too)

I did not yet really look at the actual code refactor, but the only think I was worrying a bit is: you changed the order of keyword arguments, that is right? Now you put kind second (which is very logical), before x and y. But I was wondering how many people would rely on the position of x and y? (for the others that doesn't matter I think, but for those first keyword, it does maybe)