BUG make take_nd support readonly arrays by ogrisel · Pull Request #10070 · pandas-dev/pandas (original) (raw)

@ogrisel ok, your soln looks good. I just had to make a minor correction (the indexer was being passed as a ndarray into the memview function (I think maybe from the original code), and was showing some cython warnings. Making it a memory view worked as well. And added some more tests.

As soon as this passes will merge. We are going to release 0.16.1 soon, so this will make it in.

https://github.com/jreback/pandas/tree/ogrisel-readonly-take_nd

thanks!

FYI I tried to change this to general 2 separate cython function and disambiguate at a higher level, but then I had to fix more stuff....so this is a nice work-around.