MAINT: Cleanup pandas/src/parser by gfyoung · Pull Request #14740 · pandas-dev/pandas (original) (raw)

@jreback : Here's the command I ran (after doing pip install cpplint, source code here):

cpplint --extensions=c --headers=h /home/User/Repositories/pandas/pandas/src/parser/tokenizer.c

Note: you can disable extensions: e.g. --filter=-readability/casting,-runtime/int. If you want to pipe to a file instead of everything on the terminal, just append &> <filename>

Here's what the linter is complaining about right now:

/home/User/Repositories/pandas/pandas/src/parser/tokenizer.c:20:  Include the directory when naming .h files  [build/include_subdir] [4]
/home/User/Repositories/pandas/pandas/src/parser/tokenizer.c:48:  Using C-style cast.  Use reinterpret_cast<coliter_t *>(...) instead  [readability/casting] [4]
/home/User/Repositories/pandas/pandas/src/parser/tokenizer.c:133:  Using C-style cast.  Use reinterpret_cast<parser_t *>(...) instead  [readability/casting] [4]
/home/User/Repositories/pandas/pandas/src/parser/tokenizer.c:136:  Using C-style cast.  Use reinterpret_cast<void *>(...) instead  [readability/casting] [4]
/home/User/Repositories/pandas/pandas/src/parser/tokenizer.c:137:  Using C-style cast.  Use reinterpret_cast<void *>(...) instead  [readability/casting] [4]
/home/User/Repositories/pandas/pandas/src/parser/tokenizer.c:138:  Using C-style cast.  Use reinterpret_cast<void *>(...) instead  [readability/casting] [4]
/home/User/Repositories/pandas/pandas/src/parser/tokenizer.c:139:  Using C-style cast.  Use reinterpret_cast<void *>(...) instead  [readability/casting] [4]
/home/User/Repositories/pandas/pandas/src/parser/tokenizer.c:140:  Using C-style cast.  Use reinterpret_cast<void *>(...) instead  [readability/casting] [4]
/home/User/Repositories/pandas/pandas/src/parser/tokenizer.c:148:  Using C-style cast.  Use reinterpret_cast<void *>(...) instead  [readability/casting] [4]
/home/User/Repositories/pandas/pandas/src/parser/tokenizer.c:149:  Using C-style cast.  Use reinterpret_cast<void *>(...) instead  [readability/casting] [4]
/home/User/Repositories/pandas/pandas/src/parser/tokenizer.c:152:  Using C-style cast.  Use reinterpret_cast<kh_int64_t *>(...) instead  [readability/casting] [4]
/home/User/Repositories/pandas/pandas/src/parser/tokenizer.c:185:  Using C-style cast.  Use reinterpret_cast<char *>(...) instead  [readability/casting] [4]
/home/User/Repositories/pandas/pandas/src/parser/tokenizer.c:196:  Using C-style cast.  Use reinterpret_cast<char **>(...) instead  [readability/casting] [4]
/home/User/Repositories/pandas/pandas/src/parser/tokenizer.c:197:  Using C-style cast.  Use reinterpret_cast<int *>(...) instead  [readability/casting] [4]
/home/User/Repositories/pandas/pandas/src/parser/tokenizer.c:202:  Using C-style cast.  Use reinterpret_cast<int *>(...) instead  [readability/casting] [4]
/home/User/Repositories/pandas/pandas/src/parser/tokenizer.c:204:  Using C-style cast.  Use reinterpret_cast<int *>(...) instead  [readability/casting] [4]
/home/User/Repositories/pandas/pandas/src/parser/tokenizer.c:254:  Using C-style cast.  Use reinterpret_cast<void *>(...) instead  [readability/casting] [4]
/home/User/Repositories/pandas/pandas/src/parser/tokenizer.c:258:  Using C-style cast.  Use reinterpret_cast<char *>(...) instead  [readability/casting] [4]
/home/User/Repositories/pandas/pandas/src/parser/tokenizer.c:285:  Using C-style cast.  Use reinterpret_cast<char **>(...) instead  [readability/casting] [4]
/home/User/Repositories/pandas/pandas/src/parser/tokenizer.c:301:  Using C-style cast.  Use reinterpret_cast<void *>(...) instead  [readability/casting] [4]
/home/User/Repositories/pandas/pandas/src/parser/tokenizer.c:306:  Using C-style cast.  Use reinterpret_cast<int *>(...) instead  [readability/casting] [4]
/home/User/Repositories/pandas/pandas/src/parser/tokenizer.c:315:  Using C-style cast.  Use reinterpret_cast<int *>(...) instead  [readability/casting] [4]
/home/User/Repositories/pandas/pandas/src/parser/tokenizer.c:328:  Using C-style cast.  Use reinterpret_cast<void *>(...) instead  [readability/casting] [4]
/home/User/Repositories/pandas/pandas/src/parser/tokenizer.c:333:  Using C-style cast.  Use reinterpret_cast<int *>(...) instead  [readability/casting] [4]
/home/User/Repositories/pandas/pandas/src/parser/tokenizer.c:348:  Using C-style cast.  Use reinterpret_cast<char *>(...) instead  [readability/casting] [4]
/home/User/Repositories/pandas/pandas/src/parser/tokenizer.c:364:  Using C-style cast.  Use reinterpret_cast<char *>(...) instead  [readability/casting] [4]
/home/User/Repositories/pandas/pandas/src/parser/tokenizer.c:400:  Using C-style cast.  Use reinterpret_cast<char *>(...) instead  [readability/casting] [4]
/home/User/Repositories/pandas/pandas/src/parser/tokenizer.c:401:  Almost always, snprintf is better than strcpy  [runtime/printf] [4]
/home/User/Repositories/pandas/pandas/src/parser/tokenizer.c:406:  Using C-style cast.  Use reinterpret_cast<char *>(...) instead  [readability/casting] [4]
/home/User/Repositories/pandas/pandas/src/parser/tokenizer.c:407:  Almost always, snprintf is better than strcpy  [runtime/printf] [4]
/home/User/Repositories/pandas/pandas/src/parser/tokenizer.c:458:  Using C-style cast.  Use reinterpret_cast<char *>(...) instead  [readability/casting] [4]
/home/User/Repositories/pandas/pandas/src/parser/tokenizer.c:470:  Using C-style cast.  Use reinterpret_cast<char *>(...) instead  [readability/casting] [4]
/home/User/Repositories/pandas/pandas/src/parser/tokenizer.c:471:  Never use sprintf. Use snprintf instead.  [runtime/printf] [5]
/home/User/Repositories/pandas/pandas/src/parser/tokenizer.c:501:  Using C-style cast.  Use reinterpret_cast<char *>(...) instead  [readability/casting] [4]
/home/User/Repositories/pandas/pandas/src/parser/tokenizer.c:502:  Never use sprintf. Use snprintf instead.  [runtime/printf] [5]
/home/User/Repositories/pandas/pandas/src/parser/tokenizer.c:528:  Using C-style cast.  Use reinterpret_cast<void *>(...) instead  [readability/casting] [4]
/home/User/Repositories/pandas/pandas/src/parser/tokenizer.c:531:  Using C-style cast.  Use reinterpret_cast<kh_int64_t *>(...) instead  [readability/casting] [4]
/home/User/Repositories/pandas/pandas/src/parser/tokenizer.c:561:  Using C-style cast.  Use reinterpret_cast<char *>(...) instead  [readability/casting] [4]
/home/User/Repositories/pandas/pandas/src/parser/tokenizer.c:564:  Never use sprintf. Use snprintf instead.  [runtime/printf] [5]
/home/User/Repositories/pandas/pandas/src/parser/tokenizer.c:567:  Never use sprintf. Use snprintf instead.  [runtime/printf] [5]
/home/User/Repositories/pandas/pandas/src/parser/tokenizer.c:590:  Using C-style cast.  Use reinterpret_cast<char *>(...) instead  [readability/casting] [4]
/home/User/Repositories/pandas/pandas/src/parser/tokenizer.c:591:  Never use sprintf. Use snprintf instead.  [runtime/printf] [5]
/home/User/Repositories/pandas/pandas/src/parser/tokenizer.c:675:  Using C-style cast.  Use reinterpret_cast<kh_int64_t *>(...) instead  [readability/casting] [4]
/home/User/Repositories/pandas/pandas/src/parser/tokenizer.c:676:  Using C-style cast.  Use reinterpret_cast<kh_int64_t *>(...) instead  [readability/casting] [4]
/home/User/Repositories/pandas/pandas/src/parser/tokenizer.c:684:  Use int16/int64/etc, rather than the C type long  [runtime/int] [4]
/home/User/Repositories/pandas/pandas/src/parser/tokenizer.c:991:  Using C-style cast.  Use reinterpret_cast<char *>(...) instead  [readability/casting] [4]
/home/User/Repositories/pandas/pandas/src/parser/tokenizer.c:992:  Never use sprintf. Use snprintf instead.  [runtime/printf] [5]
/home/User/Repositories/pandas/pandas/src/parser/tokenizer.c:1101:  Using C-style cast.  Use reinterpret_cast<char *>(...) instead  [readability/casting] [4]
/home/User/Repositories/pandas/pandas/src/parser/tokenizer.c:1107:  Using C-style cast.  Use reinterpret_cast<char *>(...) instead  [readability/casting] [4]
/home/User/Repositories/pandas/pandas/src/parser/tokenizer.c:1108:  Never use sprintf. Use snprintf instead.  [runtime/printf] [5]
/home/User/Repositories/pandas/pandas/src/parser/tokenizer.c:1147:  Using C-style cast.  Use reinterpret_cast<void *>(...) instead  [readability/casting] [4]
/home/User/Repositories/pandas/pandas/src/parser/tokenizer.c:1196:  Using C-style cast.  Use reinterpret_cast<void *>(...) instead  [readability/casting] [4]
/home/User/Repositories/pandas/pandas/src/parser/tokenizer.c:1200:  Using C-style cast.  Use reinterpret_cast<char **>(...) instead  [readability/casting] [4]
/home/User/Repositories/pandas/pandas/src/parser/tokenizer.c:1202:  Using C-style cast.  Use reinterpret_cast<void *>(...) instead  [readability/casting] [4]
/home/User/Repositories/pandas/pandas/src/parser/tokenizer.c:1206:  Using C-style cast.  Use reinterpret_cast<int *>(...) instead  [readability/casting] [4]
/home/User/Repositories/pandas/pandas/src/parser/tokenizer.c:1221:  Using C-style cast.  Use reinterpret_cast<void *>(...) instead  [readability/casting] [4]
/home/User/Repositories/pandas/pandas/src/parser/tokenizer.c:1231:  Using C-style cast.  Use reinterpret_cast<char *>(...) instead  [readability/casting] [4]
/home/User/Repositories/pandas/pandas/src/parser/tokenizer.c🔢  Using C-style cast.  Use reinterpret_cast<char *>(...) instead  [readability/casting] [4]
/home/User/Repositories/pandas/pandas/src/parser/tokenizer.c:1247:  Using C-style cast.  Use reinterpret_cast<void *>(...) instead  [readability/casting] [4]
/home/User/Repositories/pandas/pandas/src/parser/tokenizer.c:1251:  Using C-style cast.  Use reinterpret_cast<int *>(...) instead  [readability/casting] [4]
/home/User/Repositories/pandas/pandas/src/parser/tokenizer.c:1253:  Using C-style cast.  Use reinterpret_cast<void *>(...) instead  [readability/casting] [4]
/home/User/Repositories/pandas/pandas/src/parser/tokenizer.c:1257:  Using C-style cast.  Use reinterpret_cast<int *>(...) instead  [readability/casting] [4]
/home/User/Repositories/pandas/pandas/src/parser/tokenizer.c:1295:  Using C-style cast.  Use static_cast<int>(...) instead  [readability/casting] [4]
/home/User/Repositories/pandas/pandas/src/parser/tokenizer.c:1348:  Use int16/int64/etc, rather than the C type long  [runtime/int] [4]
/home/User/Repositories/pandas/pandas/src/parser/tokenizer.c:1371:  Almost always, snprintf is better than strcpy  [runtime/printf] [4]
/home/User/Repositories/pandas/pandas/src/parser/tokenizer.c:1399:  Use int16/int64/etc, rather than the C type long  [runtime/int] [4]
/home/User/Repositories/pandas/pandas/src/parser/tokenizer.c:1407:  Using C-style cast.  Use static_cast<int>(...) instead  [readability/casting] [4]
/home/User/Repositories/pandas/pandas/src/parser/tokenizer.c:1465:  Using C-style cast.  Use reinterpret_cast<char *>(...) instead  [readability/casting] [4]
/home/User/Repositories/pandas/pandas/src/parser/tokenizer.c:1589:  Using C-style cast.  Use reinterpret_cast<char *>(...) instead  [readability/casting] [4]
Done processing /home/User/Repositories/pandas/pandas/src/parser/tokenizer.c
Total errors found: 69