DOC: Clean-up references to v12 to v14 (both included) by topper-123 · Pull Request #17420 · pandas-dev/pandas (original) (raw)

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Conversation17 Commits5 Checks0 Files changed

Conversation

This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters

[ Show hidden characters]({{ revealButtonHref }})

closes #xxxx
tests added / passed
[x ] passes git diff upstream/master -u -- "*.py" | flake8 --diff
whatsnew entry

This is a continution of #17375 and cleans up references to old versions of pandas in the documentation.

Somme issues, I'd appreciate input on:

In enhancingperf.rst there is under "Expression Evaluation via :func:~pandas.eval (Experimental)" and "The DataFrame.eval method (Experimental)" a line ..versionadded:: 0.13.
In general I think it's a bit weird that something introduced back in 0.13 still is marked as experimental. I've let the versionadded stay for now, to somehow mark that eval is quite old even though it is experimental. Are there thoughts whether eval should still be marked experimental?

tp added 2 commits

September 2, 2017 13:55

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

couple of comments; also maybe in a separate PR we have lots of versionsdded refs in doc strings

@@ -1790,7 +1773,7 @@ Evaluation order matters

Furthermore, in chained expressions, the order may determine whether a copy is returned or not.
If an expression will set values on a copy of a slice, then a ``SettingWithCopy``
exception will be raised (this raise/warn behavior is new starting in 0.13.0)
exception will be raised.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is only a warning by default (and depends on the value of the option for raise/warn)

@@ -3078,8 +3062,7 @@ any pickled pandas object (or any other pickled object) from file:

.. warning::

Several internal refactorings, 0.13 (:ref:`Series Refactoring <whatsnew_0130.refactoring>`), and 0.15 (:ref:`Index Refactoring <whatsnew_0150.refactoring>`),
preserve compatibility with pickles created prior to these versions. However, these must

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would actually leave something this warning because this also applies for 0.19 to current

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've looked through the what's new section and can find some changes in pickling but can't find anything new about incompatibility. Could you guide me to the relevant section?

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jreback , I've made a proposal on this warning text, that is more general in nature.

If you pictured something different, let me know.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok, I've written it anew

also update link to python.org

In enhancingperf.rst there is under "Expression Evaluation via :func:~pandas.eval (Experimental)" and "The DataFrame.eval method (Experimental)" a line ..versionadded:: 0.13.
In general I think it's a bit weird that something introduced back in 0.13 still is marked as experimental. I've let the versionadded stay for now, to somehow mark that eval is quite old even though it is experimental. Are there thoughts whether eval should still be marked experimental?

yeah you can take the Experimental off.

to a cython function. Instead pass the actual ``ndarray`` using the ``.values`` attribute of the Series.

Prior to 0.13.0
So, do not do this:

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

maybe:

This will fail because the cython definition is specific to an ndarray and not the passed Series

See `here http://pandas.pydata.org/pandas-docs/stable/whatsnew.html#whatsnew-0130-refactoring`__
and `here http://pandas.pydata.org/pandas-docs/stable/whatsnew.html#whatsnew-0150-refactoring`__
for some examples of compatibility-breaking changes. See
`this question http://stackoverflow.com/questions/20444593/pandas-compiled-from-source-default-pickle-behavior-changed`__