Update ecosystem.rst to include Pint by znicholls · Pull Request #22582 · pandas-dev/pandas (original) (raw)

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Conversation20 Commits1 Checks0 Files changed

Conversation

This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters

[ Show hidden characters]({{ revealButtonHref }})

We are working on upgrading pint to be compatible with pandas, see hgrecco/pint#684

I am guessing that the line in the docs,

If you’re building a library that implements the interface, please publicize it on Extension Data Types.

meant something like this pull request. If that's completely wrong, apologies.

• closes #xxxx (N/A as not directly related to an issue, but makes progress towards ENH: unit of measurement / physical quantities #10349 )
• (N/A) tests added / passed
• (N/A) passes git diff upstream/master -u -- "*.py" | flake8 --diff *
• whatsnew entry

Codecov Report

Merging #22582 into master will not change coverage.
The diff coverage is n/a.

@@ Coverage Diff @@ ## master #22582 +/- ##

Coverage 92.29% 92.29%

Files 161 161
Lines 51497 51497

Hits 47530 47530
Misses 3967 3967

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e5c90e5...93dd398. Read the comment docs.

I’ll take a look at pint#684; units support have been an often-requested feature for pandas.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I assume that this needs a new release of pint yes? pls indicate the minimum version here.

znicholls changed the titleUpdate ecosystem.rst to include Pint WIP: Update ecosystem.rst to include Pint

Sep 4, 2018

znicholls changed the titleWIP: Update ecosystem.rst to include Pint Update ecosystem.rst to include Pint

Sep 6, 2018

any idea why this is failing..?

Looks like a CI bug that was cleared up a couple days ago. Try rebasing?

can you merge master and update

We're working on a new release of Pint (hgrecco/pint#693) but none of us can find the time right now, I hope to in January

CI is green now, is this ready to be merged, or are we waiting for the next Pint release?

@znicholls is this ready to be merged? or is a new Pint release or something else needed?

or is a new Pint release or something else needed?

Up to you guys. It will be included in the next Pint release but maybe best wait given we're still a bit uncertain about how best to do it (Panda's pytest test suite isn't playing nice with Pint's unittest test suite and we don't understand why, see hgrecco/pint#741)

Ok, I see. Thanks for the clarification. I'll then close this PR for now, but please ping us when you update Pint, so we reopen it and discuss any needed change then.

GitHub doesn't let me reopen this PR, since the branch has been forced pushed or recreated. Can you open a new PR please?

Also, the ecosystem was moved to the website, it's a different file now.

Thanks for the work on this.

Labels