Fixturize tests/frame/test_constructors.py by h-vetinari · Pull Request #25635 · pandas-dev/pandas (original) (raw)
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Conversation18 Commits6 Checks0 Files changed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
[ Show hidden characters]({{ revealButtonHref }})
One more steps towards #22471. Again, needing to re-add some fixtures that were removed in #24885.
This was referenced
Mar 10, 2019
| @@ -127,6 +127,22 @@ def timezone_frame(): |
|---|
| return df |
| @pytest.fixture |
| def datetime_series(): |
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
don't add any more here
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
not here for now
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@jreback
See above:
PS. As noted in the other threads, this is a TestData-"fixture" that's used in several modules.
This is used also used in #25627, for example
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i don't think these fixtures useful; if you really really want them put them in the actual test file for now
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
maybe my comments are crossing with your reading of them.
pandas testing functions or related to the test suite
label
Codecov Report
Merging #25635 into master will not change coverage.
The diff coverage isn/a.
@@ Coverage Diff @@ ## master #25635 +/- ##
Coverage 91.26% 91.26%
Files 173 173
Lines 52968 52968
Hits 48339 48339
Misses 4629 4629
| Flag | Coverage Δ | |
|---|---|---|
| #multiple | 89.83% <ø> (ø) | ⬆️ |
| #single | 41.71% <ø> (ø) | ⬆️ |
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact),ø = not affected,? = missing data
Powered by Codecov. Last update df771cc...f10b72c. Read the comment docs.
@jreback
All green.
PS. As noted in the other threads, this is a TestData-"fixture" that's used in several modules.
| @@ -127,6 +127,22 @@ def timezone_frame(): |
|---|
| return df |
| @pytest.fixture |
| def datetime_series(): |
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
not here for now
Contributor Author
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| @@ -127,6 +127,22 @@ def timezone_frame(): |
|---|
| return df |
| @pytest.fixture |
| def datetime_series(): |
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@jreback
See above:
PS. As noted in the other threads, this is a TestData-"fixture" that's used in several modules.
This is used also used in #25627, for example
Just for context, these fixtures had already been there (since #22236), and were only recently removed in #24885, even though I noted that there was an ongoing (is somewhat stalled) translation effort.
Can we leave the re-org for later and not re-litigate the fixtures that we already agreed to use in #22236?
| @@ -127,6 +127,22 @@ def timezone_frame(): |
|---|
| return df |
| @pytest.fixture |
| def datetime_series(): |
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i don't think these fixtures useful; if you really really want them put them in the actual test file for now
re datetime_series:
@jreback: i don't think these fixtures useful; if you really really want them put them in the actual test file for now
I agree with you, but currently tests.frame.common.TestData.ts1 is still used in several places, and will have to be on the level of tests.frame.conftest - another PR that needs the same fixture is #25627
I had merged master like you asked, this PR is not stale. Please reopen.
Labels
pandas testing functions or related to the test suite