pandas (original) (raw)

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

I agree with Brock on having consistent use of mask being better than some mask and some mask_in. I think having a function here with both mask and result_mask, I think it's clear that mask is about the input.

@jbrockmendel here or for a follow-up, but it might be good to add a benchmark for this. Based on a quick check, it seems that GroupByMethods and GroupByCythonAgg target those algos (both in benchmarks/groupby.py), and are not yet parametrized with a nullable dtype.