DEPR: deprecate Index.is_interval by ShisuiUzumaki · Pull Request #50196 · pandas-dev/pandas (original) (raw)
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Conversation20 Commits15 Checks0 Files changed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
[ Show hidden characters]({{ revealButtonHref }})
- progress towards API: Deprecate Index.is_(boolean|categorical|integer|floating|numeric|object|interval) #50042
- Tests added and passed if fixing a bug or adding a new feature
- All code checks passed.
- Added type annotations to new arguments/methods/functions.
- Added an entry in the latest
doc/source/whatsnew/v2.0.0.rstfile if fixing a bug or adding a new feature.
Looks good. The failure looks unrelated, but the ARM tests should be run again just in case.
Like @phofl said in #50178, it may be a while before we merge. I can keep an eye on this getting in in due time, if you want to focus on other things.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm, thanks @ShisuiUzumaki
@phofl I see there are just few deprecations in #30228 pending enforcement. Are we still waiting for them to merge PRs with new deprecations?
@ShisuiUzumaki You'll have to merge main and fix the conflicts in what's new before we can merge.
cc @jbrockmendel I think we talked about this as well. Haven't followed the deprecations that closely, do you think we can merge new ones?
Ideally I'd like to get #49560 and #49715 in before adding new deprecations, but not a huge deal. Other than that I'm fine with it as long as @mroeschke is.
Yeah ideally I would like to get all the old 1.x deprecations out before adding new ones, but that might not be realistic to block given wanting to release 2.0 next month or so.
I would be fine with merging new ones soon as long as we start a new deprecation tracker for 3.0 issue documenting these new ones
lgtm, thanks @ShisuiUzumaki
@phofl I see there are just few deprecations in #30228 pending enforcement. Are we still waiting for them to merge PRs with new deprecations?
@ShisuiUzumaki You'll have to merge main and fix the conflicts in what's new before we can merge.
Which branch do I have to merge main into? Are you referring to ShisuiUzumaki:index_dtype_api_deprecation? But the merge seems to create a lot of errors, I mean that many checks are falling on the GitHub side
This was referenced
Jan 5, 2023
I would be fine with merging new ones soon as long as we start a new deprecation tracker for 3.0 issue documenting these new ones
I created #50578 to track new deprecations. I also created #50579 to keep track of deprecations pending enforcement. What it makes sense to me is to have a detailed look at the code base, see what else is pending enforcement, update #50579, and when we're confident we've got everything pending enforcement under control, then we can start merging PRs with new deprecations. @mroeschke @phofl @jbrockmendel is this more or less what you have in mind to hold merging new deprecations before the rest are enforced? To make it easier to verify we don't forget any?
Needs a rebase, good to merge afterwards
Ping. Can you rebase.
On it!
Ping. Can you rebase.
Could you have a look? Also, I should mention that there were some conflicts in the .pre-commit-config.yaml file.
YEah, you need to fix the ‘. pre-commit-config.yaml ‘, else looks good and ready to merge.
YEah, you need to fix the ‘. pre-commit-config.yaml ‘, else looks good and ready to merge.
I think it is done
There is still a change in '.pre-commit-config.yaml' in this PR?
There is still a change in '.pre-commit-config.yaml' in this PR?
You mean from the main branch?
pooja-subramaniam pushed a commit to pooja-subramaniam/pandas that referenced this pull request
assertion error fix added in pandas/core/indexes/base.py
changes made to pandas/core/infexes/base.py for is_interval deprecation in class Index
changes made to pandas/tests//indexes/common.py to test deprecation of is_interval
docs/source/whatsnew/v2.0.0.rst edited for index.is_interval
changes in pandas/core/indexes/base.py - removed extra import of is_interva;_dtype
brnahc state before rebase
Fixed error in .pre-commit-config.yaml file
unwanted changed fixed in .pre-commit-cofig.yaml
Labels
Functionality to remove in pandas
Related to the Index class or subclasses