arm64: add support for libusb0 on arm64 by dontech · Pull Request #314 · pbatard/libwdi (original) (raw)

A few patches to add more ARM64 support for libwdi

…in to overwrite DLL entry

Added the problem seen in: #301

Fixed the missing files in the workflow

Thanks for this PR. The one problem I have with it is that I don't think I want to apply the last patch because it references a non-official release of libusb-win32. Libwdi and especially Zadig provides links to the SourceForge directory, and the latest official release there is still 1.2.7.3 so as long as it remains that way, I don't see myself embedding files (and a version of libusb-win32) that people who click on the libusb-win32 link in Zadig will not find under official releases.

@mcuee, do you guys plan to publish an official release of libusb-win32 with the ARM64 drivers at some stage?

Okay, then I'll wait for the 1.4.0 release then (which I don't mind, as I'm afraid this patchset is still low priority for me, but I'll try to get through this over the next couple of months).

OK i will release 1.4.0 now

Please tell me if anything else is blocking this PR

We have not uploaded there in a while, and I would prefer not to, as it would signal that SF site was still alive, which it is not. And why would libwdi prefer to download form SourceForge when it itself is hosted on github?

Update to 1.4.0.0 libusb0

Yes I also prefer to use github.

@pbatard Is that okay for you? Thanks.

I updated the libusb0 reference to 1.4.0.0 so we should be GTG! 👍

So what is the official URL for libusb-win32 now?

If it has changed, then I will have to update all the URLs that are referenced in libwdi and Zadig before I can produce a new release.

So what is the official URL for libusb-win32 now?

That is probably a bit up in the air. @mcuee started the move to github, and I sort of just followed. Sourceforge has not been updated for a long time, but still exists and refers forward to github, so I do not think there is any harm in referencing both for now.

But the download site is now github AKAIK.

Could you please sort out a single site then?

From the standpoint of users having to juggle multiple sites is not ideal. So, if you want to ditch SourceForge, and are clearly planning to leave a download section there with obsolete releases (which is going to be super confusing for users if you state that SourceForge is more or less still active), could you please make one GitHub URL the new official one?

Oh and please update SF then to state that it's obsolete and point to the new repo.

Okay, we will put a note telling the user to go to github.

@pbatard
libusb-win32 1.4.0 has been released for a while, is it possible that you apply this PR? Thanks.

I'm not sure I'll have much time for libwdi before the Rufus 4.5 release, which is still about 3 weeks away, but I'll see what I can do.

Applied. Sorry it took so long...

This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters

[ Show hidden characters]({{ revealButtonHref }})