feat: Add types for 'getDisplayName' by rschristian · Pull Request #4957 · preactjs/preact (original) (raw)

📊 Tachometer Benchmark Results

Summary

duration

create10k: unsure 🔍 -0% - +2% (-1.59ms - +18.33ms)
preact-local vs preact-main
filter-list: unsure 🔍 -0% - +0% (-0.07ms - +0.03ms)
preact-local vs preact-main
hydrate1k: unsure 🔍 -2% - +2% (-1.59ms - +1.51ms)
preact-local vs preact-main
many-updates: unsure 🔍 -1% - +1% (-0.15ms - +0.24ms)
preact-local vs preact-main
replace1k: unsure 🔍 -1% - +1% (-0.93ms - +0.49ms)
preact-local vs preact-main
text-update: unsure 🔍 -2% - +6% (-0.03ms - +0.12ms)
preact-local vs preact-main
todo: unsure 🔍 -2% - +1% (-0.48ms - +0.44ms)
preact-local vs preact-main
update10th1k: unsure 🔍 -0% - +5% (-0.15ms - +1.48ms)
preact-local vs preact-main

usedJSHeapSize

create10k: unsure 🔍 -0% - +0% (-0.00ms - +0.00ms)
preact-local vs preact-main
filter-list: unsure 🔍 -1% - +1% (-0.02ms - +0.01ms)
preact-local vs preact-main
hydrate1k: unsure 🔍 -6% - +7% (-0.36ms - +0.48ms)
preact-local vs preact-main
many-updates: unsure 🔍 -0% - +0% (-0.00ms - +0.00ms)
preact-local vs preact-main
replace1k: unsure 🔍 -0% - +0% (-0.00ms - +0.00ms)
preact-local vs preact-main
text-update: unsure 🔍 -2% - +2% (-0.02ms - +0.02ms)
preact-local vs preact-main
todo: unsure 🔍 -0% - +0% (-0.00ms - +0.00ms)
preact-local vs preact-main
update10th1k: unsure 🔍 -0% - +0% (-0.00ms - +0.00ms)
preact-local vs preact-main

Results

create10k

Browser: chrome-headless
Sample size: 50
Built by: CI #5208
Commit: 89a721c

duration

Version	Avg time	vs preact-local	vs preact-main
preact-local	975.27ms - 992.65ms	-	unsure 🔍-0% - +2%-1.59ms - +18.33ms
preact-main	970.72ms - 980.46ms	unsure 🔍-2% - +0%-18.33ms - +1.59ms	-

usedJSHeapSize

Version	Avg time	vs preact-local	vs preact-main
preact-local	19.04ms - 19.04ms	-	unsure 🔍-0% - +0%-0.00ms - +0.00ms
preact-main	19.04ms - 19.04ms	unsure 🔍-0% - +0%-0.00ms - +0.00ms	-

filter-list

Browser: chrome-headless
Sample size: 50
Built by: CI #5208
Commit: 89a721c

duration

Version	Avg time	vs preact-local	vs preact-main
preact-local	16.54ms - 16.57ms	-	unsure 🔍-0% - +0%-0.07ms - +0.03ms
preact-main	16.53ms - 16.62ms	unsure 🔍-0% - +0%-0.03ms - +0.07ms	-

usedJSHeapSize

Version	Avg time	vs preact-local	vs preact-main
preact-local	1.54ms - 1.56ms	-	unsure 🔍-1% - +1%-0.02ms - +0.01ms
preact-main	1.54ms - 1.57ms	unsure 🔍-1% - +1%-0.01ms - +0.02ms	-

hydrate1k

Browser: chrome-headless
Sample size: 90
Built by: CI #5208
Commit: 89a721c

duration

Version	Avg time	vs preact-local	vs preact-main
preact-local	72.61ms - 74.74ms	-	unsure 🔍-2% - +2%-1.59ms - +1.51ms
preact-main	72.59ms - 74.84ms	unsure 🔍-2% - +2%-1.51ms - +1.59ms	-

usedJSHeapSize

Version	Avg time	vs preact-local	vs preact-main
preact-local	6.35ms - 6.97ms	-	unsure 🔍-6% - +7%-0.36ms - +0.48ms
preact-main	6.31ms - 6.88ms	unsure 🔍-7% - +5%-0.48ms - +0.36ms	-

many-updates

Browser: chrome-headless
Sample size: 50
Built by: CI #5208
Commit: 89a721c

duration

Version	Avg time	vs preact-local	vs preact-main
preact-local	16.32ms - 16.56ms	-	unsure 🔍-1% - +1%-0.15ms - +0.24ms
preact-main	16.24ms - 16.55ms	unsure 🔍-1% - +1%-0.24ms - +0.15ms	-

usedJSHeapSize

Version	Avg time	vs preact-local	vs preact-main
preact-local	3.72ms - 3.73ms	-	unsure 🔍-0% - +0%-0.00ms - +0.00ms
preact-main	3.72ms - 3.73ms	unsure 🔍-0% - +0%-0.00ms - +0.00ms	-

replace1k

Browser: chrome-headless
Sample size: 100
Built by: CI #5208
Commit: 89a721c

duration

Version	Avg time	vs preact-local	vs preact-main
preact-local	61.74ms - 62.58ms	-	unsure 🔍-1% - +1%-0.93ms - +0.49ms
preact-main	61.81ms - 62.95ms	unsure 🔍-1% - +1%-0.49ms - +0.93ms	-

usedJSHeapSize

Version	Avg time	vs preact-local	vs preact-main
preact-local	2.99ms - 2.99ms	-	unsure 🔍-0% - +0%-0.00ms - +0.00ms
preact-main	2.99ms - 2.99ms	unsure 🔍-0% - +0%-0.00ms - +0.00ms	-

run-warmup-0

Version	Avg time	vs preact-local	vs preact-main
preact-local	26.06ms - 26.79ms	-	unsure 🔍-2% - +2%-0.55ms - +0.49ms
preact-main	26.09ms - 26.83ms	unsure 🔍-2% - +2%-0.49ms - +0.55ms	-

run-warmup-1

Version	Avg time	vs preact-local	vs preact-main
preact-local	32.34ms - 33.24ms	-	unsure 🔍-3% - +1%-0.93ms - +0.35ms
preact-main	32.63ms - 33.54ms	unsure 🔍-1% - +3%-0.35ms - +0.93ms	-

run-warmup-2

Version	Avg time	vs preact-local	vs preact-main
preact-local	33.76ms - 34.52ms	-	unsure 🔍-1% - +3%-0.21ms - +0.85ms
preact-main	33.45ms - 34.18ms	unsure 🔍-2% - +1%-0.85ms - +0.21ms	-

run-warmup-3

Version	Avg time	vs preact-local	vs preact-main
preact-local	26.05ms - 26.40ms	-	unsure 🔍-0% - +1%-0.12ms - +0.35ms
preact-main	25.95ms - 26.27ms	unsure 🔍-1% - +0%-0.35ms - +0.12ms	-

run-warmup-4

Version	Avg time	vs preact-local	vs preact-main
preact-local	25.05ms - 26.41ms	-	unsure 🔍-7% - +0%-1.80ms - +0.14ms
preact-main	25.86ms - 27.25ms	unsure 🔍-1% - +7%-0.14ms - +1.80ms	-

run-final

Version	Avg time	vs preact-local	vs preact-main
preact-local	21.21ms - 21.70ms	-	unsure 🔍-1% - +2%-0.31ms - +0.38ms
preact-main	21.19ms - 21.66ms	unsure 🔍-2% - +1%-0.38ms - +0.31ms	-

text-update

Browser: chrome-headless
Sample size: 240
Built by: CI #5208
Commit: 89a721c

duration

Version	Avg time	vs preact-local	vs preact-main
preact-local	1.90ms - 2.02ms	-	unsure 🔍-2% - +6%-0.03ms - +0.12ms
preact-main	1.87ms - 1.97ms	unsure 🔍-6% - +2%-0.12ms - +0.03ms	-

usedJSHeapSize

Version	Avg time	vs preact-local	vs preact-main
preact-local	0.99ms - 1.02ms	-	unsure 🔍-2% - +2%-0.02ms - +0.02ms
preact-main	0.99ms - 1.02ms	unsure 🔍-2% - +2%-0.02ms - +0.02ms	-

todo

Browser: chrome-headless
Sample size: 50
Built by: CI #5208
Commit: 89a721c

duration

Version	Avg time	vs preact-local	vs preact-main
preact-local	31.60ms - 32.01ms	-	unsure 🔍-2% - +1%-0.48ms - +0.44ms
preact-main	31.41ms - 32.24ms	unsure 🔍-1% - +2%-0.44ms - +0.48ms	-

usedJSHeapSize

Version	Avg time	vs preact-local	vs preact-main
preact-local	1.26ms - 1.26ms	-	unsure 🔍-0% - +0%-0.00ms - +0.00ms
preact-main	1.26ms - 1.26ms	unsure 🔍-0% - +0%-0.00ms - +0.00ms	-

update10th1k

Browser: chrome-headless
Sample size: 50
Built by: CI #5208
Commit: 89a721c

duration

Version	Avg time	vs preact-local	vs preact-main
preact-local	32.68ms - 33.84ms	-	unsure 🔍-0% - +5%-0.15ms - +1.48ms
preact-main	32.03ms - 33.17ms	unsure 🔍-4% - +0%-1.48ms - +0.15ms	-

usedJSHeapSize

Version	Avg time	vs preact-local	vs preact-main
preact-local	2.93ms - 2.94ms	-	unsure 🔍-0% - +0%-0.00ms - +0.00ms
preact-main	2.93ms - 2.94ms	unsure 🔍-0% - +0%-0.00ms - +0.00ms	-

tachometer-reporter-action v2 for CI

Size Change: 0 B

Total Size: 47.5 kB

ℹ️ View Unchanged

Filename	Size
compat/dist/compat.js	3.91 kB
compat/dist/compat.mjs	3.84 kB
compat/dist/compat.umd.js	3.96 kB
debug/dist/debug.js	3.9 kB
debug/dist/debug.mjs	3.9 kB
debug/dist/debug.umd.js	3.98 kB
devtools/dist/devtools.js	263 B
devtools/dist/devtools.mjs	273 B
devtools/dist/devtools.umd.js	348 B
dist/preact.js	4.71 kB
dist/preact.mjs	4.73 kB
dist/preact.umd.js	4.78 kB
hooks/dist/hooks.js	1.53 kB
hooks/dist/hooks.mjs	1.56 kB
hooks/dist/hooks.umd.js	1.6 kB
jsx-runtime/dist/jsxRuntime.js	892 B
jsx-runtime/dist/jsxRuntime.mjs	861 B
jsx-runtime/dist/jsxRuntime.umd.js	966 B
test-utils/dist/testUtils.js	473 B
test-utils/dist/testUtils.mjs	473 B
test-utils/dist/testUtils.umd.js	555 B

compressed-size-action

coverage: 99.442%. remained the same
when pulling 89a721c on types/getDisplayName
into 4788838 on main.

* @param {import('./internal').VNode} vnode
*
* @param {import('./internal').VNode} vnode

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Duplicate line that I thought I'd correct whilst I was at it

This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters

[ Show hidden characters]({{ revealButtonHref }})