Update Go by SuperQ · Pull Request #770 · prometheus/common (original) (raw)
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Conversation3 Commits1 Checks5 Files changed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
[ Show hidden characters]({{ revealButtonHref }})
- Update Go to support 1.24.
- Update minimum Go version to 1.23.0.
- Bump Go modules.
- Update Go to support 1.24.
- Update minimum Go version to 1.23.0.
- Bump Go modules.
Signed-off-by: SuperQ superq@gmail.com
| module github.com/prometheus/common |
|---|
| go 1.21 |
| go 1.23.0 |
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Would this force golang to set their minimum go version to 1.23 as well? I believe we're still in 1.22 over there 🤔
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, unfortunately, the upstream Go maintainers (golang.org/x/oauth2) have set this as a minimum requirement.
There's now a upstream Go bot auto-updating this: golang/oauth2@3f78298
We'll have to reconsider our support policy for client_golang versions. 😿
Ping client_golang maintainers.
Upstream Go is now bumping minimum Go versions in golang.org/x/ packages to only support the latest 2 releases. This forces us to bump our support here in order to pull in updates that include security fixes.
This is blocking some updates that are making vulnerability scanners complain. Even if there are no actual issues it would be good to move forward with updating our Go version support in common/client_golang to match.
