Expose X509_V_* constants by itamarst · Pull Request #1202 · pyca/pyopenssl (original) (raw)

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Conversation15 Commits14 Checks0 Files changed

Conversation

This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters

[ Show hidden characters]({{ revealButtonHref }})

Fixes #1201

The cryptography half of this is in pyca/cryptography#8626

Potential user hazard: As currently implemented, users of pyOpenSSL who depend on this may be setting up their users for weird errors if they happen to install cryptography 40. So possibly this should also include either:

• Changing minimal required cryptography to 41, if/when Restore the x509 error verification codes cryptography#8626 is merged and v41 released.
• Or, don't change the minimal version, but do change cryptography dependency to forbid version 40, so you'd get versions before and after.
• Or, just assume this functionality is so obscure no one is likely to hit this in practice and do nothing.

I think we're going to backport and release those bindings in 40.0.2. I think I'd prefer to avoid bumping up the minimum version as well, so we'll want to be more explicit (40.0.0 and 40.0.1) for the conditional branch. Please also add a comment that says when we bump to a 41+ minimum we can remove the branch 😄

GitHub is being very laggy :( There's a fix for the flake issue that will show up in a minute or so.

Looks like this needs a rebase and addressing the outstanding comments. We're going to do a release in the next few days so this can land if it gets done!

Ugh got distracted and didn't finish this. Will try to get to this tomorrow or next week.

OK should be ready for review again, assuming CI passes.

Can't tell if the docs issue is my fault or not.

not related, I'll do a PR momentarily to fix it.

Member

alex left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One comment, besides that this LGTM.

Co-authored-by: Alex Gaynor alex.gaynor@gmail.com

alex approved these changes Apr 29, 2023