Add SSL_CTX_set_min_proto_version/SSL_CTX_set_max_proto_version bindings by mhils · Pull Request #985 · pyca/pyopenssl (original) (raw)

Ok, removing PIP_NO_BINARY=cryptography in tox.ini fixes the ubuntu-bionic tests:

PIP_NO_BINARY=cryptography

PIP_NO_BINARY=:all: was introduced by @hynek in 8b5ee6f ("wheels make testing of various OpenSSLs on OS X impossible") and then changed to only apply to cryptography in 0c21cbd ("Banning all breaks setuptools installation").

Is there a particular (security) reason why cryptography is not installed as a wheel?

If yes, what approach shall we take for the ubuntu-bionic container build? Without wheels, it errors building cryptography.
If no, this PR should be good to go.