move da and ds fixtures to conftest.py by mathause · Pull Request #6730 · pydata/xarray (original) (raw)

This PR renames the da and ds fixtures (to da_fixture and ds_fixture) and moves them to conftest.py. This allows to remove the flake8 error suppression for the tests and seems more how the fixtures are intended to be used (from the pytest side). I think the name changes makes it a bit more obvious what happens but moving them to may make it a bit less obvious (if you don't know where to look).

Removing the flake8 error ignores also unearthed some unused imports:

(What I actually wanted to do is move the tests for rolling to it's own file - but I think it makes sense to do this first.)