version 1.18.5 breaks showPDFpage (original) (raw)

Hi,

after upgrading pymupdf from 1.18.4 to 1.18.5 I noticed that the following code doesn't work anymore:

page.showPDFpage(
    targetrect,  # fill the whole page
    self.doc,  # input document
    self.pagenr,  # input page number
    clip=sourcerect,  # part of the input page to use
)

It now fails with ValueError: bad number of positional parameters. Could you:

• document that version 1.18.5 introduced a change so that others with similar code know that this is intentional
• document how to port code from 1.18.4 to 1.18.5
• in the future, not make a backwards-incompatible change on a minor version bump

Thanks!