Drop support for Python 2.7 and Python 3.5 by pradyunsg · Pull Request #9189 · pypa/pip (original) (raw)

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Conversation3 Commits10 Checks0 Files changed

Conversation

This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters

[ Show hidden characters]({{ revealButtonHref }})

pradyunsg

Toward #8802, closes #6148

I know, I know, there's a new resolver out and we made what is quite likely one of the more disruptive changes in pip's history.

OTOH... We have a lotta code to purge, so, chop-chop.

Note that this PR doesn't actually drop any compatibility-related hacks/code. We'll do that in lots of follow up PRs. :)

hugovk

"Programming Language :: Python :: 3",
"Programming Language :: Python :: 3.5",

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could add "Programming Language :: Python :: 3 :: Only" too.

@pradyunsg

I am really happy to make this nice and short.

@pradyunsg

@pradyunsg

@pradyunsg

@pradyunsg

@pradyunsg

@pradyunsg

These versions are no longer supported.

@pradyunsg

@pradyunsg

@pradyunsg

@pradyunsg

Annd... this is ready to go! Who wants to click merge? :)

Edit: Oops, I said that slightly before the push happened. 😆

@pradyunsg

philroche pushed a commit to philroche/snapcraft that referenced this pull request

Jan 25, 2021

…ted versions

pip >=21 no longer support python3.5 or python 2 and if used will result in a broken install with pip unable to install packages.

philroche pushed a commit to philroche/snapcraft that referenced this pull request

Jan 25, 2021

…ted versions

pip >=21 no longer support python3.5 or python 2 and if used will result in a broken install with pip unable to install packages.

philroche pushed a commit to philroche/snapcraft that referenced this pull request

Jan 25, 2021

pip 21 dropped support for python 3.5 and python 2.

pip >=21 no longer support python3.5 or python 2 and if used will result in a broken install with pip unable to install packages.

philroche pushed a commit to philroche/snapcraft that referenced this pull request

Jan 25, 2021

pip 21 dropped support for python 3.5 and python 2.

pip >=21 no longer support python3.5 or python 2 and if used will result in a broken install with pip unable to install packages.

sergiusens pushed a commit to canonical/snapcraft that referenced this pull request

Jan 26, 2021

@philroche

pip 21 dropped support for python 3.5 and python 2.

pip >=21 no longer support python3.5 or python 2 and if used will result in a broken install with pip unable to install packages.

sergiusens pushed a commit to canonical/snapcraft that referenced this pull request

Jan 26, 2021

@philroche

pip 21 dropped support for python 3.5 and python 2.

pip >=21 no longer support python3.5 or python 2 and if used will result in a broken install with pip unable to install packages.

wadells added a commit to wadells/robotest that referenced this pull request

Jan 27, 2021

@wadells

This avoids the need to install python or use pip to install v1 of the cli. This recently became important because after pypa/pip#9189, pip no longer runs with many distros default python 2.7.

wadells added a commit to gravitational/robotest that referenced this pull request

Jan 27, 2021

@wadells

This avoids the need to install python or use pip to install v1 of the cli. This recently became important because after pypa/pip#9189, pip no longer runs with many distros default python 2.7.

wadells added a commit to gravitational/robotest that referenced this pull request

Jan 27, 2021

@wadells

This avoids the need to install python or use pip to install v1 of the cli. This recently became important because after pypa/pip#9189, pip no longer runs with many distros default python 2.7.

(cherry picked from commit 684f823)

bors bot referenced this pull request in duckinator/emanate

Jan 31, 2021

@bors @pyup-bot

abitrolly pushed a commit to abitrolly/snapcraft that referenced this pull request

Mar 31, 2021

@philroche @abitrolly

pip 21 dropped support for python 3.5 and python 2.

pip >=21 no longer support python3.5 or python 2 and if used will result in a broken install with pip unable to install packages.

aalexanderr added a commit to aalexanderr/fetchcode that referenced this pull request

Aug 23, 2021

@aalexanderr

WARNING: fetchcode's vcs will not work on this commit. This is result of separating pip's code from changes made in scope of this repository.

This should make it easier to track potentially replicated issues from pip when taking their vcs pkg.

It also made cleaning up easier, due to some maintenance activities done in pip:

pip._internal.vcs (and related code) changes:

In next commits, most of pip's internals will be removed from fetchcode, leaving only vcs module with supporting code (like utils functions, tests (which will be added & submitted with this change))

This will allow for changes such as ability to add return codes (probably via futures) from long running downloads and other features.

Switching to having own vcs module might also be a good call due to pip._internal.vcs close integration with pip's cli in vcs module (some pip code has been commented out in commit mentioned below)

While generally copy-pasting code without history is bad idea, this commit follows precedence set in this repo by: 8046215 with exception that all changes to pip's code will be submitted as separate commits.

It has been agreed with @pombredanne & @TG1999 that history from pip will be rebased on fetchcode by @pombredanne (thanks!). It will be done only for the files that are of concern for fetchcode to limit noise in git history.

I'm leaving this commit without SoB intentionally, as this is not my work, but that of the many pip's authors: https://github.com/pypa/pip/blob/21.2.4/AUTHORS.txt License of pip: MIT (https://pypi.org/project/pip/)

aalexanderr added a commit to aalexanderr/fetchcode that referenced this pull request

Oct 1, 2021

@aalexanderr

Please note that fetchcode's vcs might not work on this branch. Initially pip was commited without it's history and with few changes applied. This update approaches this differently- by commiting pip code in a single commit & applying changes on top of it in separate commits. While much of pip's code will be stripped from this repository, the goal of this is to make it easier to take changes from upstream, even after the code will be modified. While git-subtree could be used it brings it's own set of issues.

Update should make it easier to track potentially replicated issues from pip when taking their vcs pkg.

It also made cleaning up easier, due to some maintenance activities done in pip:

pip._internal.vcs (and related code) changes between 20.1.1 and 21.2.4

In next commits, most of pip's internals will be removed from fetchcode, leaving only vcs module with supporting code (like utils functions, tests (which will be submitted alongside this change))

This will allow for changes such as ability to add return codes (probably via futures) from long running downloads and other features.

Switching to having own vcs module might also be a good call due to pip._internal.vcs integration with pip's cli in vcs module (some pip code has been commented out in commit mentioned below)

While generally copy-pasting code (rather than using submodules/subtrees etc) makes it harder to track, my git-foo is not great enough for me to attempt regrafting subset of pips history that is of note from fetchcode perspective. It has been agreed with @pombredanne & @TG1999 that history from pip will be regrafted on fetchcode by @pombredanne (thanks!). It will be done only for the files that are of concern for fetchcode to limit noise in git history.

The code submitted in scope of this commit is work of many pip's authors that can bee seen here: https://github.com/pypa/pip/blob/21.2.4/AUTHORS.txt

Pip is licensed under MIT (https://pypi.org/project/pip/)

Signed-off-by: Alexander Mazuruk a.mazuruk@samsung.com

aalexanderr added a commit to aalexanderr/fetchcode that referenced this pull request

Oct 4, 2021

@aalexanderr

Please note that fetchcode's vcs might not work on this branch. Initially pip was commited without it's history and with few changes applied. This update approaches this differently- by commiting pip code in a single commit & applying changes on top of it in separate commits. While much of pip's code will be stripped from this repository, the goal of this is to make it easier to take changes from upstream, even after the code will be modified. While git-subtree could be used it brings it's own set of issues.

Update should make it easier to track potentially replicated issues from pip when taking their vcs pkg.

It also made cleaning up easier, due to some maintenance activities done in pip:

pip._internal.vcs (and related code) changes between 20.1.1 and 21.2.4

In next commits, most of pip's internals will be removed from fetchcode, leaving only vcs module with supporting code (like utils functions, tests (which will be submitted alongside this change))

This will allow for changes such as ability to add return codes (probably via futures) from long running downloads and other features.

Switching to having own vcs module might also be a good call due to pip._internal.vcs integration with pip's cli in vcs module (some pip code has been commented out in commit mentioned below)

While generally copy-pasting code (rather than using submodules/subtrees etc) makes it harder to track, my git-foo is not great enough for me to attempt regrafting subset of pips history that is of note from fetchcode perspective. It has been agreed with @pombredanne & @TG1999 that history from pip will be regrafted on fetchcode by @pombredanne (thanks!). It will be done only for the files that are of concern for fetchcode to limit noise in git history.

The code submitted in scope of this commit is work of many pip's authors that can bee seen here: https://github.com/pypa/pip/blob/21.2.4/AUTHORS.txt

Pip is licensed under MIT (https://pypi.org/project/pip/)

Signed-off-by: Alexander Mazuruk a.mazuruk@samsung.com

@github-actions github-actions bot locked as resolved and limited conversation to collaborators

Oct 5, 2021

2 participants

@pradyunsg @hugovk