Remove the location warnings for now by uranusjr · Pull Request #9912 · pypa/pip (original) (raw)

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Conversation4 Commits1 Checks0 Files changed

Conversation

This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters

[ Show hidden characters]({{ revealButtonHref }})

uranusjr

We can revert and discuss how we want to present the message better once Python 3.8.10 is out.

Not sure what kind of news this should use.

@pradyunsg

The removal/deprecation one?

@pradyunsg

test_locations needs an update.

Beyond that, It might be better to keep this logic, but have it be hidden behind an environment variable like _PIP_DEBUG? Regardless, as long as this PR removes the warning being printed right now, I'm on board. :)

@uranusjr

@uranusjr

I’ve amended the PR to simply make the warning DEBUG level. This should be able to hide the message from casual users, but does not risk breaking any functionalities.

sbidoul

pradyunsg

@sbidoul

@uranusjr uranusjr deleted the sysconfig-remove-warning-for-python-release branch

May 4, 2021 07:01

inmantaci added a commit to inmanta/inmanta-core that referenced this pull request

May 18, 2021

@inmantaci

@github-actions github-actions bot locked as resolved and limited conversation to collaborators

Sep 29, 2021