Replace f-string with "...".format(...) by vstinner · Pull Request #146 · python/core-workflow (original) (raw)

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Conversation9 Commits1 Checks0 Files changed

Conversation

This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters

[ Show hidden characters]({{ revealButtonHref }})

vstinner

Change adding Python 3.5 support.

@vstinner

Change adding Python 3.5 support.

@vstinner

Alternate syntax of PR #143, again, to add Python 3.5 compatibility.

brettcannon

1st1
fields = [x.strip() for x in filename.split(".")]
assert len(fields) >= 4, f"Can't parse 'next' filename! filename {filename!r} fields {fields}"
assert len(fields) >= 4, "Can't parse 'next' filename! filename {!r} fields {}".format(filename, fields)

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This line is surely longer than 79 characters.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The PEP 8 allows up to 120 characters. The file already contains lines longer than 120 characters (before my change) ;-)

1st1

1st1 approved these changes Jun 26, 2017

@serhiy-storchaka

Thank you for doing this @Haypo!

@serhiy-storchaka

Brett, could you please update the version on PyPI? Current version is installable on 3.5, but doesn't work.

@brettcannon

@serhiy-storchaka sure, but I'm traveling ATM so I won't be able to get to it until I return home (no later than sometime next week).

@Mariatta

Prior to releasing to PyPI, I think this line in flit.ini should be updated so it can work with Python < 3.6.

The readme still states "blurb's only dependency is Python 3.6+.", guess that should be updated too.

@brettcannon

I updated the version number, tweaked the trove classifiers, fixed the README, pushed 1.0.1 to PyPI, and then bumped the version number for future development.

@serhiy-storchaka

Unfortunately

python3 -m pip install --user blurb

still installs version 1.0. And explicit specifying the version 1.0.1 doesn't work.

$ python3 -m pip install --user blurb==1.0.1
Collecting blurb==1.0.1
  Could not find a version that satisfies the requirement blurb==1.0.1 (from versions: 1.0)
No matching distribution found for blurb==1.0.1