bpo-24813: IDLE: Add default title to help_about (#2366) · python/cpython@18ede06 (original) (raw)

`@@ -2,7 +2,7 @@

`

2

2

``

3

3

`"""

`

4

4

`import os

`

5

``

`-

from sys import version

`

``

5

`+

from platform import python_version

`

6

6

``

7

7

`from tkinter import Toplevel, Frame, Label, Button, PhotoImage

`

8

8

`from tkinter import SUNKEN, TOP, BOTTOM, LEFT, X, BOTH, W, EW, NSEW, E

`

`@@ -14,7 +14,7 @@ class AboutDialog(Toplevel):

`

14

14

`"""Modal about dialog for idle

`

15

15

``

16

16

` """

`

17

``

`-

def init(self, parent, title, _htest=False, _utest=False):

`

``

17

`+

def init(self, parent, title=None, _htest=False, _utest=False):

`

18

18

`"""Create popup, do not return until tk widget destroyed.

`

19

19

``

20

20

` parent - parent of this dialog

`

`@@ -32,7 +32,7 @@ def init(self, parent, title, _htest=False, _utest=False):

`

32

32

`self.fg = "#ffffff"

`

33

33

`self.create_widgets()

`

34

34

`self.resizable(height=False, width=False)

`

35

``

`-

self.title(title)

`

``

35

`+

self.title(title or f'About IDLE {python_version()}')

`

36

36

`self.transient(parent)

`

37

37

`self.grab_set()

`

38

38

`self.protocol("WM_DELETE_WINDOW", self.ok)

`

`@@ -48,7 +48,6 @@ def init(self, parent, title, _htest=False, _utest=False):

`

48

48

`self.wait_window()

`

49

49

``

50

50

`def create_widgets(self):

`

51

``

`-

release = version[:version.index(' ')]

`

52

51

`frame = Frame(self, borderwidth=2, relief=SUNKEN)

`

53

52

`frame_buttons = Frame(self)

`

54

53

`frame_buttons.pack(side=BOTTOM, fill=X)

`

`@@ -80,15 +79,16 @@ def create_widgets(self):

`

80

79

`justify=LEFT, fg=self.fg, bg=self.bg)

`

81

80

`email.grid(row=6, column=0, columnspan=2, sticky=W, padx=10, pady=0)

`

82

81

`docs = Label(frame_background, text='https://docs.python.org/' +

`

83

``

`-

version[:3] + '/library/idle.html',

`

``

82

`+

python_version()[:3] + '/library/idle.html',

`

84

83

`justify=LEFT, fg=self.fg, bg=self.bg)

`

85

84

`docs.grid(row=7, column=0, columnspan=2, sticky=W, padx=10, pady=0)

`

86

85

``

87

86

`Frame(frame_background, borderwidth=1, relief=SUNKEN,

`

88

87

`height=2, bg=self.bg).grid(row=8, column=0, sticky=EW,

`

89

88

`columnspan=3, padx=5, pady=5)

`

90

89

``

91

``

`-

pyver = Label(frame_background, text='Python version: ' + release,

`

``

90

`+

pyver = Label(frame_background,

`

``

91

`+

text='Python version: ' + python_version(),

`

92

92

`fg=self.fg, bg=self.bg)

`

93

93

`pyver.grid(row=9, column=0, sticky=W, padx=10, pady=0)

`

94

94

`tkver = Label(frame_background, text='Tk version: ' + tk_patchlevel,

`

`@@ -113,7 +113,8 @@ def create_widgets(self):

`

113

113

`height=2, bg=self.bg).grid(row=11, column=0, sticky=EW,

`

114

114

`columnspan=3, padx=5, pady=5)

`

115

115

``

116

``

`-

idlever = Label(frame_background, text='IDLE version: ' + release,

`

``

116

`+

idlever = Label(frame_background,

`

``

117

`+

text='IDLE version: ' + python_version(),

`

117

118

`fg=self.fg, bg=self.bg)

`

118

119

`idlever.grid(row=12, column=0, sticky=W, padx=10, pady=0)

`

119

120

`idle_buttons = Frame(frame_background, bg=self.bg)

`