bpo-26133: Fix typos (GH-5010) (#5014) · python/cpython@32518b4 (original) (raw)

2 files changed

lines changed

Original file line number Diff line number Diff line change
@@ -66,9 +66,9 @@ def close(self):
66 66 self.remove_signal_handler(sig)
67 67 else:
68 68 if self._signal_handlers:
69 -warinigs.warn(f"Closing the loop {self!r} "
69 +warnings.warn(f"Closing the loop {self!r} "
70 70 f"on interpreter shutdown "
71 -f"stage, signal unsubsription is disabled",
71 +f"stage, skipping signal handlers removal",
72 72 ResourceWarning,
73 73 source=self)
74 74 self._signal_handlers.clear()
Original file line number Diff line number Diff line change
@@ -230,6 +230,23 @@ def test_close(self, m_signal):
230 230 self.assertEqual(len(self.loop._signal_handlers), 0)
231 231 m_signal.set_wakeup_fd.assert_called_once_with(-1)
232 232
233 +@mock.patch('asyncio.unix_events.sys')
234 +@mock.patch('asyncio.unix_events.signal')
235 +def test_close_on_finalizing(self, m_signal, m_sys):
236 +m_signal.NSIG = signal.NSIG
237 +self.loop.add_signal_handler(signal.SIGHUP, lambda: True)
238 +
239 +self.assertEqual(len(self.loop._signal_handlers), 1)
240 +m_sys.is_finalizing.return_value = True
241 +m_signal.signal.reset_mock()
242 +
243 +with self.assertWarnsRegex(ResourceWarning,
244 +"skipping signal handlers removal"):
245 +self.loop.close()
246 +
247 +self.assertEqual(len(self.loop._signal_handlers), 0)
248 +self.assertFalse(m_signal.signal.called)
249 +
233 250
234 251 @unittest.skipUnless(hasattr(socket, 'AF_UNIX'),
235 252 'UNIX Sockets are not supported')