gh-113174: Sync with importlib_metadata 7.0 by jaraco · Pull Request #113175 · python/cpython (original) (raw)

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Conversation15 Commits8 Checks0 Files changed

Conversation

This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters

[ Show hidden characters]({{ revealButtonHref }})

jaraco

@hugovk

Sync with importlib_metadata 7.0, including improved type annotations, fixed
issue with symlinked packages in package_distributions, added
EntryPoints.__repr__, introduced the diagnose script, added
Distribution.origin property, and removed deprecated EntryPoint
access by numeric index (tuple behavior).

Will there be docs changes in this PR or another?

@jaraco

Will there be docs changes in this PR or another?

I've added docs in b610b6d. I chose not to mention some of the changes as they seemed incidental enough not to affect most users.

@jaraco jaraco marked this pull request as ready for review

December 15, 2023 15:13

hugovk

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would this also benefit from an entry in What's New in Python 3.13?

@jaraco

Would this also benefit from an entry in What's New in Python 3.13?

Perhaps. I'd consider mentioning the EntryPoint.__getitem__ removal and new Distribution.origin property, though I expect most users not to care much. Overall, I'm thinking it'd be more noise than value, so I'll propose not to add anything, but I'd be happy to add something if anyone feels otherwise.

AlexWaygood

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree with @hugovk that the removal of EntryPoint.__getitem__ should be mentioned in "What's New". It doesn't need to be a prominent mention near the top of the document, but we should try to make sure that all backwards-incompatible changes are mentioned somewhere in that document, in my opinion.

@jaraco @AlexWaygood

Co-authored-by: Alex Waygood Alex.Waygood@Gmail.com

@jaraco

@jaraco

AlexWaygood

@jaraco @AlexWaygood

Co-authored-by: Alex Waygood Alex.Waygood@Gmail.com

@jaraco

@jaraco

Today I learned about the syntax (docs). The exclamation point means to ignore EntryPoint because it isn't documented.

@jaraco

Thanks for the review. Merging, but happy to revisit if needed.

@jaraco jaraco deleted the feature/113174-importlib-metadata-7.0 branch

December 21, 2023 20:04

ryan-duve pushed a commit to ryan-duve/cpython that referenced this pull request

Dec 26, 2023

Co-authored-by: Alex Waygood Alex.Waygood@Gmail.com

Co-authored-by: Alex Waygood Alex.Waygood@Gmail.com

Co-authored-by: Alex Waygood Alex.Waygood@Gmail.com

@ambv

@ambv

I worked around the problem by enabling SeCreateSymbolicLinkPrivilege for the buildbot user, but ultimately I believe the test should be skipped for users without this privilege set.

kulikjak pushed a commit to kulikjak/cpython that referenced this pull request

Jan 22, 2024

Co-authored-by: Alex Waygood Alex.Waygood@Gmail.com

Co-authored-by: Alex Waygood Alex.Waygood@Gmail.com

Co-authored-by: Alex Waygood Alex.Waygood@Gmail.com

aisk pushed a commit to aisk/cpython that referenced this pull request

Feb 11, 2024

Co-authored-by: Alex Waygood Alex.Waygood@Gmail.com

Co-authored-by: Alex Waygood Alex.Waygood@Gmail.com

Co-authored-by: Alex Waygood Alex.Waygood@Gmail.com

Glyphack pushed a commit to Glyphack/cpython that referenced this pull request

Sep 2, 2024

Co-authored-by: Alex Waygood Alex.Waygood@Gmail.com

Co-authored-by: Alex Waygood Alex.Waygood@Gmail.com

Co-authored-by: Alex Waygood Alex.Waygood@Gmail.com