gh-100288: Specialise LOAD_ATTR_METHOD for managed dictionaries by Fidget-Spinner · Pull Request #100289 · python/cpython (original) (raw)

Well looks like I'm reverting PRs for Christmas... this PR introduced a race condition in test___xxxsubinterpreters on Windows. I had to run this with -F and it only crashed after 10 runs.

Thread 0x00000430 (most recent call first):
  File "D:\a\1\s\Lib\test\test__xxsubinterpreters.py", line 812 in test_create_thread
  File "D:\a\1\s\Lib\unittest\case.py", line 579 in _callTestMethod
  File "D:\a\1\s\Lib\unittest\case.py", line 623 in run
  File "D:\a\1\s\Lib\unittest\case.py", line 678 in __call__
  File "D:\a\1\s\Lib\unittest\suite.py", line 122 in run
  File "D:\a\1\s\Lib\unittest\suite.py", line 84 in __call__
  File "D:\a\1\s\Lib\unittest\suite.py", line 122 in run
  File "D:\a\1\s\Lib\unittest\suite.py", line 84 in __call__
  File "D:\a\1\s\Lib\unittest\suite.py", line 122 in run
  File "D:\a\1\s\Lib\unittest\suite.py", line 84 in __call__
  File "D:\a\1\s\Lib\unittest\runner.py", line 208 in run
  File "D:\a\1\s\Lib\test\support\__init__.py", line 1100 in _run_suite
  File "D:\a\1\s\Lib\test\support\__init__.py", line 1226 in run_unittest
  File "D:\a\1\s\Lib\test\libregrtest\runtest.py", line 281 in _test_module
  File "D:\a\1\s\Lib\test\libregrtest\runtest.py", line 317 in _runtest_inner2
  File "D:\a\1\s\Lib\test\libregrtest\runtest.py", line 360 in _runtest_inner
  File "D:\a\1\s\Lib\test\libregrtest\runtest.py", line 235 in _runtest
  File "D:\a\1\s\Lib\test\libregrtest\runtest.py", line 265 in runtest
  File "D:\a\1\s\Lib\test\libregrtest\main.py", line 353 in rerun_failed_tests
  File "D:\a\1\s\Lib\test\libregrtest\main.py", line 756 in _main
  File "D:\a\1\s\Lib\test\libregrtest\main.py", line 711 in main
  File "D:\a\1\s\Lib\test\libregrtest\main.py", line 775 in main
  File "D:\a\1\s\Lib\test\__main__.py", line 2 in <module>
  File "<frozen runpy>", line 88 in _run_code
  File "<frozen runpy>", line 198 in _run_module_as_main
##[error]Cmd.exe exited with code '-1073741819'.