gh-73936: Support unicode passwords in smtplib by arnt · Pull Request #103611 · python/cpython (original) (raw)

I see that two older pull requests do much the same thing, but weren't merged because of missing copyright assignments and perhaps missing tests. They also didn't quite implement the specification, which requires SASLprep. (SASLprep governs, basically, when two unicode logins/passwords are equal.)

AFAICT my tests cover the same ground as the tests in the other branches, without wasting CPU time on repeatedly testing the same thing. Precisely how much to repeat is of course a matter of taste.

Mongodb very graciously contributes its SASLprep implementation, and requests that he company be added in the contributors list. I'd like to make sure that that's done at the same time as this is merged.

I am doing this for my employer, ICANN, which doesn't strictly need to be added to the contributor list but perhaps it's nice. I can sign any and all copyright assignments necessary.

While writing this, I had the impression that some of the SASL work is repeated a little too much — that imaplib and smtplib ought to share SASL code. If you agree, I could try another (separate) PR for that.

• Issue: smtplib doesn't handle unicode passwords #73936