bpo-35194: Fix a wrong constant in cp932 codec by izbyshev · Pull Request #10420 · python/cpython (original) (raw)
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Conversation9 Commits1 Checks0 Files changed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
[ Show hidden characters]({{ revealButtonHref }})
This typo doesn't affect the result because wrong bits are discarded
on implicit conversion to unsigned char, but it trips UBSan
with -fsanitize=implicit-integer-truncation.
https://bugs.python.org/issue35194
This typo doesn't affect the result because wrong bits are discarded on implicit conversion to unsigned char, but it trips UBSan with -fsanitize=implicit-integer-truncation.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good or wrong, this change would require a test to check the behavior.
@methane: do you know who can review such change?
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this fix is obvious enough.
Thanks @izbyshev for the PR 🌮🎉.. I'm working now to backport this PR to: 3.6, 3.7.
🐍🍒⛏🤖
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request
This typo doesn't affect the result because wrong bits are discarded on implicit conversion to unsigned char, but it trips UBSan with -fsanitize=implicit-integer-truncation.
https://bugs.python.org/issue35194 (cherry picked from commit 7a69cf4)
Co-authored-by: Alexey Izbyshev izbyshev@ispras.ru
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request
This typo doesn't affect the result because wrong bits are discarded on implicit conversion to unsigned char, but it trips UBSan with -fsanitize=implicit-integer-truncation.
https://bugs.python.org/issue35194 (cherry picked from commit 7a69cf4)
Co-authored-by: Alexey Izbyshev izbyshev@ispras.ru
Thanks @izbyshev for the PR 🌮🎉.. I'm working now to backport this PR to: 2.7.
🐍🍒⛏🤖
Sorry, @izbyshev, I could not cleanly backport this to 2.7 due to a conflict.
Please backport using cherry_picker on command line.cherry_picker 7a69cf47a9bbc95f95fd67c982bff121b2a903cb 2.7
miss-islington added a commit that referenced this pull request
This typo doesn't affect the result because wrong bits are discarded on implicit conversion to unsigned char, but it trips UBSan with -fsanitize=implicit-integer-truncation.
https://bugs.python.org/issue35194 (cherry picked from commit 7a69cf4)
Co-authored-by: Alexey Izbyshev izbyshev@ispras.ru
miss-islington added a commit that referenced this pull request
This typo doesn't affect the result because wrong bits are discarded on implicit conversion to unsigned char, but it trips UBSan with -fsanitize=implicit-integer-truncation.
https://bugs.python.org/issue35194 (cherry picked from commit 7a69cf4)
Co-authored-by: Alexey Izbyshev izbyshev@ispras.ru
izbyshev pushed a commit to izbyshev/cpython that referenced this pull request
This typo doesn't affect the result because wrong bits are discarded on implicit conversion to unsigned char, but it trips UBSan with -fsanitize=implicit-integer-truncation.
https://bugs.python.org/issue35194. (cherry picked from commit 7a69cf4)
Co-authored-by: Alexey Izbyshev izbyshev@ispras.ru
serhiy-storchaka pushed a commit that referenced this pull request
This typo doesn't affect the result because wrong bits are discarded on implicit conversion to unsigned char, but it trips UBSan with -fsanitize=implicit-integer-truncation. (cherry picked from commit 7a69cf4)
Co-authored-by: Alexey Izbyshev izbyshev@ispras.ru