GH-103480: make sysconfig a package (GH-110785) by FFY00 · Pull Request #110785 · python/cpython (original) (raw)

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Conversation5 Commits3 Checks0 Files changed

Conversation

This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters

[ Show hidden characters]({{ revealButtonHref }})

FFY00

Member

@FFY00 FFY00 commented

Oct 12, 2023

•

edited by bedevere-appbot

Loading

In preparation for the new API, this patch makes sysconfig a package. It has been a long time coming and open up several possibilities for improvements — it will allow us to more easily improve the import time, extend the CLI, have better separation between the code logic, etc.

@FFY00

Signed-off-by: Filipe Laíns lains@riseup.net

@FFY00

Signed-off-by: Filipe Laíns lains@riseup.net

@FFY00

@zooba, just pinging you for a sanity check on the change, since you have some interest in sysconfig. I'd fell a bit better merging this if other person ack-ed it.

Please let me know if you'd like me avoiding doing that in the future.

@zooba

Looks good to me. You can feel free to keep pinging me on this stuff (that's not an open invite for anyone to do it!)

I think this may be worth a NEWS item. Just something simple, but enough that if someone freaks out because they were using internal function that are now moved, they'll be able to find an item acknowledging that we changed something (even though it shouldn't be visible... well... any change is always noticed by someone 😉 )

@FFY00

@FFY00

Signed-off-by: Filipe Laíns lains@riseup.net

@FFY00 FFY00 changed the titleGH-103480: make sysconfig a package GH-103480: make sysconfig a package (GH-110785)

Oct 12, 2023

zooba

@bedevere-bot

⚠️⚠️⚠️ Buildbot failure ⚠️⚠️⚠️

Hi! The buildbot s390x Debian 3.x has failed when building commit 4a53a39.

What do you need to do:

  1. Don't panic.
  2. Check the buildbot page in the devguide if you don't know what the buildbots are or how they work.
  3. Go to the page of the buildbot that failed (https://buildbot.python.org/all/#builders/49/builds/6891) and take a look at the build logs.
  4. Check if the failure is related to this commit (4a53a39) or if it is a false positive.
  5. If the failure is related to this commit, please, reflect that on the issue and make a new Pull Request with a fix.

You can take a look at the buildbot page here:

https://buildbot.python.org/all/#builders/49/builds/6891

Failed tests:

Failed subtests:

Summary of the results of the build (if available):

==

Click to see traceback logs

Traceback (most recent call last): File "/home/dje/cpython-buildarea/3.x.edelsohn-debian-z/build/Lib/test/test_tools/test_freeze.py", line 33, in test_freeze_simple_script executable = helper.freeze(python, scriptfile, outdir) ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ File "/home/dje/cpython-buildarea/3.x.edelsohn-debian-z/build/Tools/freeze/test/freeze.py", line 169, in freeze _run_quiet([python, '-E', FREEZE, '-o', outdir, scriptfile], cwd=outdir) File "/home/dje/cpython-buildarea/3.x.edelsohn-debian-z/build/Tools/freeze/test/freeze.py", line 35, in _run_quiet return subprocess.run( ^^^^^^^^^^^^^^^ File "/home/dje/cpython-buildarea/3.x.edelsohn-debian-z/build/Lib/subprocess.py", line 571, in run raise CalledProcessError(retcode, process.args, subprocess.CalledProcessError: Command '['/tmp/test_python_iwbkfopc/tmpfwqvbf4v/python-installation/bin/python3', '-E', '/home/dje/cpython-buildarea/3.x.edelsohn-debian-z/build/Tools/freeze/freeze.py', '-o', '/tmp/test_python_iwbkfopc/tmpfwqvbf4v', '/tmp/test_python_iwbkfopc/tmpfwqvbf4v/app.py']' returned non-zero exit status 1.

Traceback (most recent call last): File "/home/dje/cpython-buildarea/3.x.edelsohn-debian-z/build/Tools/freeze/freeze.py", line 96, in import sysconfig ModuleNotFoundError: No module named 'sysconfig'

Traceback (most recent call last): File "/home/dje/cpython-buildarea/3.x.edelsohn-debian-z/build/Lib/test/test_tools/test_freeze.py", line 33, in test_freeze_simple_script executable = helper.freeze(python, scriptfile, outdir) ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ File "/home/dje/cpython-buildarea/3.x.edelsohn-debian-z/build/Tools/freeze/test/freeze.py", line 169, in freeze _run_quiet([python, '-E', FREEZE, '-o', outdir, scriptfile], cwd=outdir) File "/home/dje/cpython-buildarea/3.x.edelsohn-debian-z/build/Tools/freeze/test/freeze.py", line 35, in _run_quiet return subprocess.run( ^^^^^^^^^^^^^^^ File "/home/dje/cpython-buildarea/3.x.edelsohn-debian-z/build/Lib/subprocess.py", line 571, in run raise CalledProcessError(retcode, process.args, subprocess.CalledProcessError: Command '['/tmp/test_python_w1ng9ean/tmpc5qpg50a/python-installation/bin/python3', '-E', '/home/dje/cpython-buildarea/3.x.edelsohn-debian-z/build/Tools/freeze/freeze.py', '-o', '/tmp/test_python_w1ng9ean/tmpc5qpg50a', '/tmp/test_python_w1ng9ean/tmpc5qpg50a/app.py']' returned non-zero exit status 1.

@bedevere-bot

⚠️⚠️⚠️ Buildbot failure ⚠️⚠️⚠️

Hi! The buildbot s390x SLES 3.x has failed when building commit 4a53a39.

What do you need to do:

  1. Don't panic.
  2. Check the buildbot page in the devguide if you don't know what the buildbots are or how they work.
  3. Go to the page of the buildbot that failed (https://buildbot.python.org/all/#builders/540/builds/6854) and take a look at the build logs.
  4. Check if the failure is related to this commit (4a53a39) or if it is a false positive.
  5. If the failure is related to this commit, please, reflect that on the issue and make a new Pull Request with a fix.

You can take a look at the buildbot page here:

https://buildbot.python.org/all/#builders/540/builds/6854

Failed tests:

Failed subtests:

Summary of the results of the build (if available):

==

Click to see traceback logs

Traceback (most recent call last): File "/home/dje/cpython-buildarea/3.x.edelsohn-sles-z/build/Lib/test/test_tools/test_freeze.py", line 33, in test_freeze_simple_script executable = helper.freeze(python, scriptfile, outdir) ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ File "/home/dje/cpython-buildarea/3.x.edelsohn-sles-z/build/Tools/freeze/test/freeze.py", line 169, in freeze _run_quiet([python, '-E', FREEZE, '-o', outdir, scriptfile], cwd=outdir) File "/home/dje/cpython-buildarea/3.x.edelsohn-sles-z/build/Tools/freeze/test/freeze.py", line 35, in _run_quiet return subprocess.run( ^^^^^^^^^^^^^^^ File "/home/dje/cpython-buildarea/3.x.edelsohn-sles-z/build/Lib/subprocess.py", line 571, in run raise CalledProcessError(retcode, process.args, subprocess.CalledProcessError: Command '['/tmp/test_python_b1_p0vku/tmp1tabnyue/python-installation/bin/python3', '-E', '/home/dje/cpython-buildarea/3.x.edelsohn-sles-z/build/Tools/freeze/freeze.py', '-o', '/tmp/test_python_b1_p0vku/tmp1tabnyue', '/tmp/test_python_b1_p0vku/tmp1tabnyue/app.py']' returned non-zero exit status 1.

Traceback (most recent call last): File "/home/dje/cpython-buildarea/3.x.edelsohn-sles-z/build/Tools/freeze/freeze.py", line 96, in import sysconfig ModuleNotFoundError: No module named 'sysconfig'

Traceback (most recent call last): File "/home/dje/cpython-buildarea/3.x.edelsohn-sles-z/build/Lib/test/test_tools/test_freeze.py", line 33, in test_freeze_simple_script executable = helper.freeze(python, scriptfile, outdir) ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ File "/home/dje/cpython-buildarea/3.x.edelsohn-sles-z/build/Tools/freeze/test/freeze.py", line 169, in freeze _run_quiet([python, '-E', FREEZE, '-o', outdir, scriptfile], cwd=outdir) File "/home/dje/cpython-buildarea/3.x.edelsohn-sles-z/build/Tools/freeze/test/freeze.py", line 35, in _run_quiet return subprocess.run( ^^^^^^^^^^^^^^^ File "/home/dje/cpython-buildarea/3.x.edelsohn-sles-z/build/Lib/subprocess.py", line 571, in run raise CalledProcessError(retcode, process.args, subprocess.CalledProcessError: Command '['/tmp/test_python_6j7lkjum/tmpve36r7ly/python-installation/bin/python3', '-E', '/home/dje/cpython-buildarea/3.x.edelsohn-sles-z/build/Tools/freeze/freeze.py', '-o', '/tmp/test_python_6j7lkjum/tmpve36r7ly', '/tmp/test_python_6j7lkjum/tmpve36r7ly/app.py']' returned non-zero exit status 1.

@FFY00 FFY00 mentioned this pull request

Oct 13, 2023

Glyphack pushed a commit to Glyphack/cpython that referenced this pull request

Sep 2, 2024

@FFY00 @Glyphack