cpython (original) (raw)

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Conversation8 Commits4 Checks0 Files changed

Conversation

This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters

[ Show hidden characters]({{ revealButtonHref }})

Mention bpo-28929 in the Documentation section of:

What's New in Python 3.7.0 alpha 1?
What's New in Python 3.6.1 release candidate 1?
What's New in Python 3.5.4 release candidate 1?

http://bugs.python.org/issue28929

mention bpo-28929 in the Documentation section of:

What's New in Python 3.7.0 alpha 1?
What's New in Python 3.6.1 release candidate 1?
What's New in Python 3.5.4 release candidate 1?

http://bugs.python.org/issue28929

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We typically don't worry about covering NEWS entries more than once in a single copy of the file since it's redundant information at that point; as long as someone reading the release notes in a release can see the news entry somewhere then that's enough.

@@ -700,6 +700,8 @@ C API
Documentation
-------------

- bpo-28929: Link the documentation to its source file on GitHub

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missing a period.

@@ -909,6 +911,8 @@ Windows
Documentation
-------------

- bpo-28929: Link the documentation to its source file on GitHub

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is unnecessary as the same bit of information is picked up in the 3.7 release notes.

@@ -4095,6 +4099,17 @@ C API
instead of TypeError on programmical error in parsing format string.


What's New in Python 3.5.4 release candidate 1?

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is also unnecessary.

I suppose it doesn't need backport then. But please re-add the labels if I'm mistaken.

You can still backport into the appropriate sections, I'm just saying you don't need it more than once in the file at any one time.

And I'm now on vacation so I'll let someone else approve. 😀

Ah ok I think I got it now 😅 Re-added the backport labels.

Please enjoy your vacation!

This was referenced

Feb 25, 2017

akruis referenced this pull request in stackless-dev/stackless

Sep 5, 2017

akruis referenced this pull request in stackless-dev/stackless

Sep 5, 2017

…s and test_xml_etree

Disable the recently added test methods test_copy() and test_pickle() in test_dictviews, test_generators and test_xml_etree. Theses test assure that objects can't be copied or pickled, but Stackless can copy/pickle them.

https://bitbucket.org/stackless-dev/stackless/issues/112

akruis referenced this pull request in stackless-dev/stackless

Sep 5, 2017

Fix the recently added test test_pdb.test_pdb_issue_20766. This test depends on undefined behaviour of C-Python (invalid value of frame.f_lineno if frame.f_trace is None). Stackless-Python behaves differently, if soft-switching is enabled. This change disables soft-switching for this test.

https://bitbucket.org/stackless-dev/stackless/issues/112

akruis referenced this pull request in stackless-dev/stackless

Sep 5, 2017

akruis referenced this pull request in stackless-dev/stackless

Sep 5, 2017

akruis referenced this pull request in stackless-dev/stackless

Sep 5, 2017