[2.7] bpo-35441: Remove dead and buggy code related to PyList_SetItem(). (GH-11033) by serhiy-storchaka · Pull Request #11234 · python/cpython (original) (raw)

Copy link

Member

@serhiy-storchaka serhiy-storchaka commented

Dec 19, 2018

edited by bedevere-bot

Loading

In _localemodule.c and selectmodule.c, remove dead code that would
cause double decrefs if run.

In addition, replace PyList_SetItem() with PyList_SET_ITEM() in cases
where a new list is populated and there is no possibility of an error.

In addition, check if the list changed size in the loop in array_array_fromlist().
(cherry picked from commit 99d56b5)

Co-authored-by: Zackery Spytz zspytz@gmail.com

https://bugs.python.org/issue35441