bpo-35717: Fix KeyError exception raised when using enums and compile by remilapeyre · Pull Request #11523 · python/cpython (original) (raw)
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Conversation17 Commits3 Checks0 Files changed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
[ Show hidden characters]({{ revealButtonHref }})
bpo-17467: Fix KeyError exception raised when using enums and compile bpo-35717: Fix KeyError exception raised when using enums and compile
A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated.
Once you have made the requested changes, please leave a comment on this pull request containing the phrase I have made the requested changes; please review again. I will then notify any core developers who have left a review that you're ready for them to take another look at this pull request.
I have made the requested changes; please review again
Thanks for making the requested changes!
@ethanfurman: please review the changes made to this pull request.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good.
Now add yourself to Misc/ACKS. :)
A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated.
Once you have made the requested changes, please leave a comment on this pull request containing the phrase I have made the requested changes; please review again. I will then notify any core developers who have left a review that you're ready for them to take another look at this pull request.
Thanks @ethanfurman, I have made the requested changes; please review again.
Thanks for making the requested changes!
@ethanfurman: please review the changes made to this pull request.
Thank you. As soon as I get this on my machine for final checks I'll move it forward. :)
Now add yourself to Misc/ACKS. :)
Honestly, I don't think that it it's still important since we moved to Git: the author is know tracked in Git.
Note: There is a "thanks.python.org" project similar to https://thanks.rust-lang.org/ cc @pablogsal
Note: There is a "thanks.python.org" project similar to https://thanks.rust-lang.org/ cc @pablogsal
Sadly, it was cancelled as in the core dev sprint it was decided not worth the maintenance cost.
Thanks @remilapeyre for the PR 🌮🎉.. I'm working now to backport this PR to: 3.7.
🐍🍒⛏🤖
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request
vstinner pushed a commit that referenced this pull request
