bpo-35954: Clarify string conversion in ConfigParser by remilapeyre · Pull Request #11918 · python/cpython (original) (raw)
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
[ Show hidden characters]({{ revealButtonHref }})
Stale PR or inactive for long period of time.
label
@remilapeyre, it looks like the decision on the bug tracker was to make this a doc change. If you can, please make that requested change or, otherwise, please close the pull request. Thank you!
Rémi Lapeyre added 2 commits
Stale PR or inactive for long period of time.
label
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Apologies for the delay reviewing this! I like the direction, but would like some changes before this goes in.
A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated.
Once you have made the requested changes, please leave a comment on this pull request containing the phrase I have made the requested changes; please review again. I will then notify any core developers who have left a review that you're ready for them to take another look at this pull request.
bpo-35954: Convert key to string when accessing ConfigParser bpo-35954: Clarify string conversion in ConfigParser
Thanks @taleinat for the review! I have made the requested changes; please review again
Thanks for making the requested changes!
@taleinat: please review the changes made to this pull request.
Co-authored-by: Irit Katriel 1055913+iritkatriel@users.noreply.github.com