bpo-36049: added repr() for the queue.PriorityQueue and queue.LifoQueue classes by zahash · Pull Request #11938 · python/cpython (original) (raw)

Hi @zahash

  1. for the blurb entry
    blurb is a tool that we use for the documentation of a PR, without that we can not accept a PR (excepted in some cases, Typo fix,...)

You should use blurb you can read this article from @Mariatta where she explains how to use blurb_it (a web service) if you don't want to use the blurb tool (it's a CLI)

  1. for the tests,
    When you modify the code you have to check if the tests will continue to be executed in the future.
    For that, you need to execute the tests with ./python -m test test_queue.py -v in this case. For that, you have compile python on your computer
> ./configure --prefix=$PWD --with-pydebug`
> make -j 4
> ./python -m test test test_queue.py -v

Once you have finished these steps you will have tested your code and your patch.

In my PR, I have modified Lib/queue.py and Lib/test/test_queue.py and executed the tests.

but one thing, and maybe the most essential, you have to read the devguide
https://devguide.python.org, in this document we expain all the things to know for the contirbuting in Python.

Good luck.