bpo-36010: Add venv to the nuget distribution by pfmoore · Pull Request #12367 · python/cpython (original) (raw)

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Conversation7 Commits5 Checks0 Files changed

Conversation

This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters

[ Show hidden characters]({{ revealButtonHref }})

pfmoore changed the title~~Add venv to the nuget distribution~~ bpo-36010: Add venv to the nuget distribution

Mar 16, 2019

Note: See the comment on bpo, but as it stands this PR does not achieve the desired effect of adding venv to the nuget package.

"stable",
"distutils",
"venv",
"launchers",

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I suspect we don't actually want this one. The original option was "launcher" (no "s"), which means it isn't including this.

IIRC, "launchers" is specific to the APPX package.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, the include_launchers option is only referenced in one place and looks like this:

if ns.include_launchers and ns.include_appxmanifest: if ns.include_pip: yield from in_build("python_uwp.exe", new_name="pip") if ns.include_idle: yield from in_build("pythonw_uwp.exe", new_name="idle")

So no need for it here