bpo-34745: Fix asyncio sslproto memory issues by fantix · Pull Request #12386 · python/cpython (original) (raw)

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Conversation7 Commits4 Checks0 Files changed

Conversation

This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters

[ Show hidden characters]({{ revealButtonHref }})

fantix

These issues are not strictly memory leaks, but they do affect the memory footprint and garbage collection if called frequently.

https://bugs.python.org/issue34745

Before the fix:

cpython-bpo-issue

After the fix:

cpython-bpo-fixed

@fantix

@fantix

@fantix

@fantix

1st1

1st1 approved these changes Mar 17, 2019

@miss-islington

Thanks @fantix for the PR, and @1st1 for merging it 🌮🎉.. I'm working now to backport this PR to: 3.6, 3.7.
🐍🍒⛏🤖

@bedevere-bot

@miss-islington

Sorry, @fantix and @1st1, I could not cleanly backport this to 3.6 due to a conflict.
Please backport using cherry_picker on command line.
cherry_picker f683f464259715d620777d7ed568e701337a703a 3.6

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request

Mar 17, 2019

@fantix @miss-islington

Refs MagicStack/uvloopGH-222

Co-authored-by: Fantix King fantix.king@gmail.com

@1st1

@fantix Could you please make a pr against 3.6?

@fantix

@1st1 sure thing, thanks for the quick response!

miss-islington added a commit that referenced this pull request

Mar 17, 2019

@miss-islington @fantix

Refs MagicStack/uvloopGH-222

Co-authored-by: Fantix King fantix.king@gmail.com

@fantix fantix deleted the fix-sslproto-handshake-timeout-leak branch

March 18, 2019 04:34

fantix added a commit to fantix/cpython that referenced this pull request

Mar 18, 2019

@fantix

@bedevere-bot

@sepetnit

Hi guys, sorry for reopening such an old issue. I'm just playing with asyncio+ssl.
My python version is 3.6.9; my asyncio version is 3.4.3. I still see the memory leak.
What can I upgrade in order to have this issue fixed in my current environment?

Thanks a lot,